feat: add useAccountName #6429
Merged
feat: add useAccountName #6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanbinrui
commented
Jun 6, 2022
nuanyang233
force-pushed
the
feat/use-account-name
branch
from
bb1bb37 to
6fd115e
Compare
nuanyang233
force-pushed
the
feat/use-account-name
branch
from
3cef71a to
edce4ce
Compare
etouyang
added a commit
to etouyang/Maskbook
that referenced
this pull request
Jun 7, 2022
* 'develop' of github.com:etouyang/Maskbook: (173 commits) feat: more debugger connection actions (DimensionDev#6438) fix: sign tx by wallet with mnemonic words (DimensionDev#6437) fix: sign arbitrary message (DimensionDev#6436) fix: bugfix for refactor (DimensionDev#6434) fix: lost overrides (DimensionDev#6435) feat: add useAccountName (DimensionDev#6429) fix: button logic under EVM chain (DimensionDev#6431) fix: gas price fallback (DimensionDev#6432) chore: update node-version for workspace (DimensionDev#6428) refactor: social address list (DimensionDev#6410) fix: bugfix for trader (DimensionDev#6424) fix: duplicated db fetch (DimensionDev#6426) docs(i18n): sync i18n files from Crowdin (DimensionDev#6425) fix: tsc need restart to handle new file or removed file in watch mode fix: lint errors feat: referral farms (DimensionDev#6128) fix: fixup maskbox for evm migrate (DimensionDev#6395) fix: pets artblocks plugin (DimensionDev#6393) docs: update compat table refactor: add RecentTransactionComputed (DimensionDev#6420) ... # Conflicts: # packages/dashboard/src/initialization/isolated_bridge.ts # packages/mask/src/extension/dashboard/index.tsx # packages/mask/src/plugins/Pets/SNSAdaptor/PetSetDialog.tsx # packages/mask/src/plugins/Pets/SNSAdaptor/PreviewBox.tsx # packages/mask/src/plugins/Pets/Services/rss3.ts # packages/mask/src/plugins/Pets/hooks/useNfts.ts # packages/shared/src/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the new web3 infra, the wallet DB only serves for Mask wallets. We don't keep wallet records for external wallets anymore. In this PR,
useAccountNameis added for reading the name of external wallets.namein the wallet record.Closes # (NO_ISSUE)
Type of change