Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tips entrance #6012

Merged
merged 209 commits into from
Apr 24, 2022
Merged

feat: tips entrance #6012

merged 209 commits into from
Apr 24, 2022

Conversation

BillySh1
Copy link
Contributor

Description

Closes # MF-280

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@BillySh1 BillySh1 marked this pull request as draft March 31, 2022 11:57
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2022

@github-actions github-actions bot temporarily deployed to pull request March 31, 2022 12:03 Inactive
@yisiliu yisiliu changed the title feat: tips enterance feat: tips entrance Apr 5, 2022
@github-actions github-actions bot temporarily deployed to pull request April 23, 2022 18:57 Inactive
lelenei
lelenei previously approved these changes Apr 24, 2022
UncleBill
UncleBill previously approved these changes Apr 24, 2022
@zhouhanseng zhouhanseng dismissed stale reviews from UncleBill and lelenei via d41dbac April 24, 2022 02:32
@github-actions github-actions bot temporarily deployed to pull request April 24, 2022 02:41 Inactive
@BillySh1 BillySh1 merged commit 6c6b28f into develop Apr 24, 2022
@BillySh1 BillySh1 deleted the feat/tips-enterance branch April 24, 2022 03:11
yanzhihong23 added a commit that referenced this pull request Apr 24, 2022
* develop: (143 commits)
  feat: tips entrance (#6012)
  refactor: remove unused plugin entries
  chore: patch @solana/web3.js (#6125)
  New translations en-US.json (Quenya) (#6131)
  New translations en-US.json (Quenya) (#6126)
  feat: new intial persona page (#6122)
  chore: turn on fortmatic (#6127)
  fix: if phantom is locked, might not able to open its popup (#6115)
  fix: reduce jsx nested (#6124)
  fix: duplicate render by unique key (#6123)
  docs(i18n): sync i18n files from Crowdin (#6119)
  feat: manage recent pending transactions (#6055)
  chore: add conflux config (#6112)
  fix: type error (#6113)
  feat: improve mask popup (#5986)
  feat: new app board (#6018)
  fix(tip): set significant to 6 for formatting max amount (#6062)
  fix: ITO history default icon (#6078)
  feat: add <ConcealableTabs /> (#6073)
  fix: if gulp biuld-ci fails, ci should fail as well (#6107)
  ...
yanzhihong23 added a commit that referenced this pull request Apr 24, 2022
* develop: (94 commits)
  fix: mnemonic words exports (#6136)
  feat: tips entrance (#6012)
  refactor: remove unused plugin entries
  chore: patch @solana/web3.js (#6125)
  New translations en-US.json (Quenya) (#6131)
  New translations en-US.json (Quenya) (#6126)
  feat: new intial persona page (#6122)
  chore: turn on fortmatic (#6127)
  fix: if phantom is locked, might not able to open its popup (#6115)
  fix: reduce jsx nested (#6124)
  fix: duplicate render by unique key (#6123)
  docs(i18n): sync i18n files from Crowdin (#6119)
  feat: manage recent pending transactions (#6055)
  chore: add conflux config (#6112)
  fix: type error (#6113)
  feat: improve mask popup (#5986)
  feat: new app board (#6018)
  fix(tip): set significant to 6 for formatting max amount (#6062)
  fix: ITO history default icon (#6078)
  feat: add <ConcealableTabs /> (#6073)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants