Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade packages #10795

Merged
merged 14 commits into from
Sep 20, 2023
Merged

chore: upgrade packages #10795

merged 14 commits into from
Sep 20, 2023

Conversation

guanbinrui
Copy link
Member

@guanbinrui guanbinrui commented Sep 19, 2023

Description

Closes MF-0000

Closes #10721
Closes #10784
Closes #10785
Closes #10786
Closes #10794

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@guanbinrui guanbinrui added this to the 2.23.0 milestone Sep 19, 2023
@github-actions github-actions bot temporarily deployed to pull request September 19, 2023 08:58 Inactive
@guanbinrui guanbinrui marked this pull request as ready for review September 19, 2023 09:04
@guanbinrui guanbinrui modified the milestones: 2.23.0, 2.24.0 Sep 19, 2023
@github-actions github-actions bot temporarily deployed to pull request September 19, 2023 09:07 Inactive
package.json Outdated
"@walletconnect/socket-transport@1.7.8": "patches/@walletconnect__socket-transport@1.7.8.patch"
"@walletconnect/socket-transport@1.7.8": "patches/@walletconnect__socket-transport@1.7.8.patch",
"web3-core@1.10.2": "patches/web3-core@1.10.2.patch",
"web3@1.10.2": "patches/web3@1.10.2.patch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web3 already has 4.1.2, do we need to stick on v1? cc @guanbinrui

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid we should. They maintain completely different APIs.

Jack-Works
Jack-Works previously approved these changes Sep 20, 2023
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 02:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 08:09 Inactive
@guanbinrui guanbinrui force-pushed the refactor/upgrade-packages branch from ae0f48f to ac1de7a Compare September 20, 2023 08:10
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 08:15 Inactive
@guanbinrui guanbinrui force-pushed the refactor/upgrade-packages branch from df21d7b to 3db2e1e Compare September 20, 2023 08:51
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 08:54 Inactive
@guanbinrui guanbinrui force-pushed the refactor/upgrade-packages branch from a4c0155 to 57b51d1 Compare September 20, 2023 08:59
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 09:01 Inactive
@guanbinrui guanbinrui force-pushed the refactor/upgrade-packages branch from 57b51d1 to 29d590d Compare September 20, 2023 09:09
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 09:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 09:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 09:27 Inactive
@guanbinrui guanbinrui force-pushed the refactor/upgrade-packages branch from 6e85a65 to 0ead8c1 Compare September 20, 2023 09:39
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 09:42 Inactive
@guanbinrui guanbinrui force-pushed the refactor/upgrade-packages branch from 656d423 to b0a3f2f Compare September 20, 2023 09:46
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 09:49 Inactive
@guanbinrui guanbinrui force-pushed the refactor/upgrade-packages branch from b0a3f2f to 12717b9 Compare September 20, 2023 10:11
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 10:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 12:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 12:29 Inactive
@guanbinrui guanbinrui merged commit 0d63377 into develop Sep 20, 2023
@guanbinrui guanbinrui deleted the refactor/upgrade-packages branch September 20, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants