-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade packages #10795
Merged
Merged
chore: upgrade packages #10795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Works
reviewed
Sep 20, 2023
package.json
Outdated
"@walletconnect/socket-transport@1.7.8": "patches/@walletconnect__socket-transport@1.7.8.patch" | ||
"@walletconnect/socket-transport@1.7.8": "patches/@walletconnect__socket-transport@1.7.8.patch", | ||
"web3-core@1.10.2": "patches/web3-core@1.10.2.patch", | ||
"web3@1.10.2": "patches/web3@1.10.2.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web3 already has 4.1.2, do we need to stick on v1? cc @guanbinrui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid we should. They maintain completely different APIs.
Jack-Works
previously approved these changes
Sep 20, 2023
ae0f48f
to
ac1de7a
Compare
df21d7b
to
3db2e1e
Compare
a4c0155
to
57b51d1
Compare
57b51d1
to
29d590d
Compare
6e85a65
to
0ead8c1
Compare
656d423
to
b0a3f2f
Compare
b0a3f2f
to
12717b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes MF-0000
Closes #10721
Closes #10784
Closes #10785
Closes #10786
Closes #10794
Type of change
Previews
Checklist
console.log
sIf this PR depends on external APIs:
chrome-extension://[id]
moz-extension://[id]