Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: popup interface that does deconstructPayload and/or verifyOthersProve #107

Closed
Artoria2e5 opened this issue Aug 14, 2019 · 8 comments · May be fixed by Jsn2win/Maskbook#15
Closed
Assignees
Labels

Comments

@Artoria2e5
Copy link
Contributor

This could be an easier path to working around some failures than going into the console and messing with the exposed services even for Power Users (TM).

WebExt popup

@Artoria2e5 Artoria2e5 changed the title Feature: popupinterface that does deconstructPayload and/or verifyOthersProve Feature: popup interface that does deconstructPayload and/or verifyOthersProve Aug 14, 2019
@SunriseFox
Copy link
Contributor

This ext shall work on both chrome and firefox, desktop and mobile... It seems not work quite well on mobile, e.g., a new tab have to be opened... And is it supported by chrome too? Emm...The key issue is that, should we really need to expose the errors to end users, and which kinds of errors need we do?... a lot to consider before adopting that...

@Artoria2e5
Copy link
Contributor Author

Artoria2e5 commented Aug 14, 2019

mobile screen is narrow, so i don't really think turning a popup into a new tab is a major usability issue; in fact it probably is the only logical way to translate such a thing into mobile.

and about that... jw wants to put it into the main option page as a dev option thing. i am currently working on that as it does not require me to write a new page lmao

@SunriseFox
Copy link
Contributor

SunriseFox commented Aug 15, 2019

So... What do we need to put on the popup?

e.g.:

  • A toggle to switch Maskbook on and off
  • A quick preview to get / set current identity, persona, profile, etc.
  • A inspector / auditor to overview the current status, such as, whether it is initialized, errors encountered, etc.
  • A quick link to our settings page / dashboard
  • A bottom navigator with several buttons to maskbook.com / github / etc.

@neruthes @Artoria2e5

@Tedko
Copy link
Member

Tedko commented Aug 15, 2019 via email

@Tedko Tedko added the Platform: Web browser Chrome-like and Firefox (WebExtension) label Aug 15, 2019
@Artoria2e5
Copy link
Contributor Author

Artoria2e5 commented Aug 15, 2019

We don't have anything on persona yet, so 2 has to wait. 4 can be done with the browser.runtime.openOptionsPage() /* please catch 4 storybook */ thing, and I guess it will be a button. For 3 there isn't really a thing for "opening inspector on this window object" so... are we making our own little textbuffer there?

// plz catch
        <Button variant="contained" onClick={(e) => }>
            OPTIONSSS!!!!!
        </Button>

@Tedko
Copy link
Member

Tedko commented Aug 15, 2019

@Artoria2e5 you can do it. Let's see @neruthes 's opinion

@neruthes
Copy link
Contributor

@Artoria2e5 you can do it. Let's see @neruthes 's opinion

Let the current path continue. We will clear things up in #70.

@Tedko
Copy link
Member

Tedko commented Sep 4, 2019

For the latest Chrome Store ver, at least we have the pop up. : ) What's the next step and how about #70 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants