Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomplete API key migration #4682

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Feb 22, 2025

Description

Fixes incomplete API key migration.

Addressed Issue

Fixes #4652
Fixes #4683

Additional Details

Tested the following steps for H2, MSSQL, and PostgreSQL:

  1. Deploy DT v4.8.2.
  2. Create API key (legacy format, no prefix) for Automation team.
  3. Deploy DT v4.12.5.
  4. Create API key (legacy format, with prefix) for Automation team.
  5. Deploy DT v4.13.0-SNAPSHOT.
  6. Create API key (new format) for Automation team.
  7. Deploy build of this PR.
  8. Check whether all previously created API keys work.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the defect Something isn't working label Feb 22, 2025
@nscuro nscuro added this to the 4.13 milestone Feb 22, 2025
Copy link

codacy-production bot commented Feb 22, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 80.95% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (297f3b2) 23115 18548 80.24%
Head commit (0b73ab1) 23123 (+8) 18552 (+4) 80.23% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4682) 21 17 80.95%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Fixes DependencyTrack#4652
Fixes DependencyTrack#4683

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro marked this pull request as ready for review February 23, 2025 14:50
@nscuro nscuro merged commit 8cab3ea into DependencyTrack:master Feb 23, 2025
11 checks passed
@nscuro nscuro deleted the issue-4652 branch February 23, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
1 participant