Remove need for libokapi.a and okapi.h when building go libraries #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Can we ensure some support for arm64, too, while we're at the point of reworking this? |
|
I'll verify again, but arm64 was already supported. :) I've run this on a raspberry pi. |
|
Built and tested on my M1 macbook air, confirms functionality. |
fundthmcalculus
changed the title
2 tasks
tmarkovski
reviewed
May 11, 2022
tmarkovski
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #404 - and can throw a library not found error. LOL.
On windows, we use
syscall.LoadDLLand no CGO required at all. On MacOS and Linux, we use dlopen to find the function pointer which is called from a bit of CGO in the header. This doesn't eliminate the CGO requirement, but eliminates the need to install theokapi.handlibokapi.afiles