Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oberon proof size assertions #378

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Add oberon proof size assertions #378

merged 1 commit into from
Mar 4, 2022

Conversation

tmarkovski
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022 •
edited
Loading

Java Test Report

12 files  ±0  12 suites  ±0   2s ⏱️ -1s
17 tests ±0  17 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
39 runs  ±0  39 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9521c6d. ± Comparison against base commit c3b5b9f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022 •
edited
Loading

Python Test Report

  12 files  ±0    12 suites  ±0   16s ⏱️ -1s
  12 tests ±0    12 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
144 runs  ±0  144 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9521c6d. ± Comparison against base commit c3b5b9f.

♻️ This comment has been updated with latest results.

@tmarkovski tmarkovski force-pushed the TM/proof-size-test branch from ef7d8b2 to 4a51065 Compare March 3, 2022 13:31
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022 •
edited
Loading

Golang Test Report

  3 files    3 suites   0s ⏱️
14 tests 14 ✔️ 0 💤 0 ❌
42 runs  42 ✔️ 0 💤 0 ❌

Results for commit 9521c6d.

♻️ This comment has been updated with latest results.

@tmarkovski tmarkovski force-pushed the TM/proof-size-test branch from 4a51065 to 9521c6d Compare March 3, 2022 13:35
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

.NET Test Report

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 9521c6d.

@tmarkovski tmarkovski enabled auto-merge (squash) March 3, 2022 13:43
fundthmcalculus
fundthmcalculus reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@fundthmcalculus fundthmcalculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we forcing the full 256 bytes of proof to be sent? Some languages only send the first 64.

@tmarkovski
Copy link
Contributor Author

Are we forcing the full 256 bytes of proof to be sent? Some languages only send the first 64.

Which ones?

@fundthmcalculus
Copy link
Contributor

Are we forcing the full 256 bytes of proof to be sent? Some languages only send the first 64.

Which ones?

off the top of my head, I don't remember. Some of the language-specific blake3 bindings are different. Now that we have blake3 exposed via okapi, it won't be an issue. I'll track this verification work here: https://github.com/trinsic-id/sdk/issues/456

@tmarkovski
Copy link
Contributor Author

This is related to proof size of oberon. It wouldn't work with any other partial size. It used to be 96 bytes, now it's 256.

@fundthmcalculus
Copy link
Contributor

This is related to proof size of oberon. It wouldn't work with any other partial size. It used to be 96 bytes, now it's 256.

ah okay. I was referring to the blake3 hashed nonce in sdk. Still something to change, but less related than I thought.

@tmarkovski
Copy link
Contributor Author

@fundthmcalculus This can't be merged without your approval. Mind giving it thumbs up?

@tmarkovski tmarkovski merged commit 50dc332 into main Mar 4, 2022
@tmarkovski tmarkovski deleted the TM/proof-size-test branch March 4, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethjback sethjback sethjback approved these changes

@fundthmcalculus fundthmcalculus fundthmcalculus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmarkovski @fundthmcalculus @sethjback