Fix mypy errors and add github actions job #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
SouthEndMusic
approved these changes
May 19, 2023
.github/workflows/python_lint.yml
Outdated
| environment-file: ./environment.yml | ||
| - name: Run mypy | ||
| run: | | ||
| mypy --ignore-missing-imports python/ribasim |
There was a problem hiding this comment.
Should this run only on the ribasim subdirectory? Also add newline at the end.
There was a problem hiding this comment.
Unfortunately, it is hard to do that locally because of this: pypa/setuptools#3518
However, we don't hit that on the CI so I've added it.
This is my first draft of how to add a new node type. Please let me know if anything is incorrect or incomplete in such a way that I can fix it, so that it helps me understand the code better. Informed by #205. --------- Co-authored-by: Bart de Koning <bart123-4@hotmail.com> Co-authored-by: Martijn Visser <mgvisser@gmail.com>
I made sure that the node representation in the ribasim python graph plot and the QGIS plugin are consistent (in terms of marker and color) and added an option for a legend in the ribasim python plot:  --------- Co-authored-by: Bart de Koning <bart123-4@hotmail.com> Co-authored-by: Martijn Visser <mgvisser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy found a couple of mistakes, plus a bit of unused code.
Sidenote:
python/ribasimis currently a bit too dynamic for my taste