Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the example block in it's entirety #548

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

dekode-kevin
Copy link
Contributor

@dekode-kevin dekode-kevin commented Jan 24, 2025

Short introduction

Remove the example block in the theme in it's entirety.

Description

We don't recommend adding the blocks in the theme folder, so it doesn't make sense for it being there. We also generally suggest using the scripts for creating blocks. Added some documetation about using the package.json script to create new blocks.
Scripts:

"create-block": "cd packages/plugins && npx dekodeinteraktiv/create-project-base-block",
"create-innerblock-block": "cd packages/plugins && npx dekodeinteraktiv/create-project-base-block --template innerblocks",

stian-overasen
stian-overasen previously approved these changes Jan 24, 2025
luistinygod
luistinygod previously approved these changes Jan 24, 2025
Copy link
Contributor

@luistinygod luistinygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree with removing custom blocks from theme package.

@dekode-kevin dekode-kevin merged commit 9cc4a49 into main Jan 24, 2025
4 checks passed
@dekode-kevin dekode-kevin deleted the remove/example-block branch January 24, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants