Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Sec Hub compliance.py not importing FindingId correctly - bug #9912

Closed
wants to merge 47 commits into from
Closed
Changes from 4 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
1a869bf
Bug - Enhancement - AWS Sec Hub
testaccount90009 Apr 10, 2024
950775b
Merge branch 'DefectDojo:dev' into dev
testaccount90009 Apr 15, 2024
d7110a7
Revert original changes - update description
testaccount90009 Apr 15, 2024
abaf669
Merge branch 'dev' of https://github.com/testaccount90009/django-Defe…
testaccount90009 Apr 15, 2024
ad1dbe5
Enhance aws sec hub descriptions
testaccount90009 Apr 16, 2024
4753af3
Update inspector.py
testaccount90009 Apr 16, 2024
6520e7b
Add GeneratorId and Mitigation
testaccount90009 Apr 16, 2024
1c0205e
Merge branch 'DefectDojo:dev' into dev
testaccount90009 Apr 17, 2024
cceeba5
Add ResourceId to Description
testaccount90009 Apr 17, 2024
ec74a11
Add Resource ID to guardduty and inspector
testaccount90009 Apr 17, 2024
9c46335
Fix formatting
testaccount90009 Apr 17, 2024
eeeca96
Merge branch 'DefectDojo:dev' into dev
testaccount90009 Apr 18, 2024
e88af0b
Attempt to fix added ResourceId
testaccount90009 Apr 18, 2024
1c968b0
Attempt to fix formatting
testaccount90009 Apr 18, 2024
280a073
Fix description
testaccount90009 Apr 18, 2024
c809ebe
Fix ResourceId add
testaccount90009 Apr 18, 2024
b0556cf
Removing ResourceId reference
testaccount90009 Apr 18, 2024
89109c7
Try adding ResourceId again
testaccount90009 Apr 18, 2024
c37e270
Fix get on list object error
testaccount90009 Apr 18, 2024
85d751c
Add space for Ruff Linter
testaccount90009 Apr 18, 2024
964c610
Update to avoid resource_id conflict
testaccount90009 Apr 18, 2024
17e9233
Update dojo/tools/awssecurityhub/inspector.py
testaccount90009 Apr 22, 2024
9601956
Update dojo/tools/awssecurityhub/compliance.py
testaccount90009 Apr 22, 2024
f773bc8
Update dojo/tools/awssecurityhub/compliance.py
testaccount90009 Apr 22, 2024
1e8f7f2
Update dojo/tools/awssecurityhub/compliance.py
testaccount90009 Apr 22, 2024
8936db4
Update dojo/tools/awssecurityhub/compliance.py
testaccount90009 Apr 22, 2024
9fdefb3
Update dojo/tools/awssecurityhub/guardduty.py
testaccount90009 Apr 22, 2024
f284918
Update compliance.py
testaccount90009 Apr 22, 2024
4ff46d4
Fix f-string expression part cannot include backslash L23
testaccount90009 Apr 22, 2024
2cd4c06
Remove join for resource_arns
testaccount90009 Apr 22, 2024
228b92a
Merge branch 'DefectDojo:dev' into dev
testaccount90009 Apr 23, 2024
154ccfd
Merge branch 'DefectDojo:dev' into dev
testaccount90009 Apr 23, 2024
fb61d52
Update test_awssecurityhub_parser.py
testaccount90009 Apr 23, 2024
22ed081
Merge branch 'dev' of https://github.com/testaccount90009/django-Defe…
testaccount90009 Apr 23, 2024
401dde2
Fix formatting
testaccount90009 Apr 23, 2024
255f0c8
Update test_awssecurityhub_parser.py
testaccount90009 Apr 23, 2024
0be0e55
Fix formatting v2?
testaccount90009 Apr 23, 2024
5d49b5d
Merge branch 'DefectDojo:dev' into dev
testaccount90009 Apr 23, 2024
8607b3d
Fix resource_id call
testaccount90009 Apr 23, 2024
dc9afa8
Rework 'findings' call in unit test
testaccount90009 Apr 23, 2024
2ae2e42
Change self assertion value
testaccount90009 Apr 24, 2024
9131483
Attempt to fix test_resource_arn new unittest
testaccount90009 Apr 24, 2024
0940134
Change double quote to single quote
testaccount90009 Apr 24, 2024
45203ad
Merge branch 'DefectDojo:dev' into dev
testaccount90009 Apr 24, 2024
0e9b699
Merge branch 'DefectDojo:dev' into dev
testaccount90009 Apr 29, 2024
953f86d
Removing failing unit test for now
testaccount90009 Apr 30, 2024
a625878
Merge branch 'DefectDojo:dev' into dev
testaccount90009 Apr 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dojo/tools/awssecurityhub/compliance.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ def get_item(self, finding: dict, test):
epss_score = None
mitigation = finding.get("Remediation", {}).get("Recommendation", {}).get("Text", "")
description = "This is a Security Hub Finding \n" + finding.get("Description", "")
description += f"\n**AWS Finding ARN:** {finding_id}\n"
if finding.get("Compliance", {}).get("Status", "PASSED") == "PASSED":
is_Mitigated = True
active = False
Expand Down
Loading