Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to reflect multiple SLA Configurations #9844

Merged
merged 6 commits into from
Mar 30, 2024

Conversation

paulOsinski
Copy link
Contributor

@paulOsinski paulOsinski commented Mar 28, 2024

The documented process for creating an SLA configuration is out of date, along with the screenshot.

These documentation changes are intended to capture how SLA configurations currently work, since the ability to work with multiple SLA configurations has been added.

@github-actions github-actions bot added the docs label Mar 28, 2024
Copy link

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Sensitive Functions Analyzer 0 findings
Configured Sensitive Files Analyzer 0 findings
Sensitive Files Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@paulOsinski paulOsinski changed the title Update documentation for multiple SLA Configurations Update documentation to reflect multiple SLA Configurations Mar 28, 2024
@@ -414,14 +414,15 @@ Similar Findings
DefectDojo allows you to maintain your security SLAs and automatically
remind teams whenever a SLA is about to get breached, or is breached.

Simply indicate in the `System Settings` for each severity, how many
days teams have to remediate a finding.
To use with SLAs, open the `System Settings` page and click the 'Enable Finding SLAs' checkbox.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to apply SLAs to findings, open System Settings and check 'Enable Finding SLAs'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -1,4 +1,4 @@
---
f---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "f"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry for missing that one

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

(assuming @manuel-sommer changes get done)

Copy link
Contributor

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting so I can commit this suggestion

@mtesauro mtesauro merged commit ad13bae into DefectDojo:dev Mar 30, 2024
121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants