Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nancy: migrate from cve to unsaved_vulnerability_ids #9834

Merged
merged 1 commit into from
Apr 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dojo/tools/nancy/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ def get_items(self, vulnerable, test):
static_finding=True,
dynamic_finding=False,
vuln_id_from_tool=associated_vuln["Id"],
cve=associated_vuln['Cve'],
references="\n".join(references),
)

Expand Down
2 changes: 2 additions & 0 deletions unittests/tools/test_nancy_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ def test_nancy_parser_with_one_vuln_has_one_findings(self):
self.assertEqual('Info', finding.severity)
self.assertIsNotNone(finding.description)
self.assertGreater(len(finding.description), 0)
self.assertEqual(None, finding.cve)
self.assertEqual("CVE-2017-1000070", finding.unsaved_vulnerability_ids[0])
self.assertEqual("CVSS:3.0/AV:N/AC:L/PR:N/UI:R/S:C/C:L/I:L/A:N", finding.cvssv3)

def test_nancy_plus_parser_with_many_vuln_has_many_findings(self):
Expand Down
Loading