Findings endpoint name truncated change #9789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in findings: show full url, wrap it, cap column at 65%
…first 80 chars, show full endpoint name it "title"
…breadcrumbs/endpoint view/etc)
…an see the full thing
|
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Tip Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example... Powered by DryRun Security |
cneill
approved these changes
Mar 20, 2024
Maffooch
approved these changes
Mar 25, 2024
grendel513
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch changes how endpoint names are displayed. Previously, for endpoints with more than 50 characters, only the last 47 characters were displayed; now, the first 80 characters are displayed, and a 'title' attribute is added to display the full name on hover. Additionally, endpoint breadcrumbs have been updated to display only the first 15 characters.
Example finding view before:
Example finding view after:
Example endpoint view before:
Example endpoint view after:
Test results
Testing done manually.
Documentation
No documentation added.
[sc-3455]