Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force to use DjangoDivFormRenderer #9659

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Mar 1, 2024

This setting is here to override default renderer of forms (use div-based, instred of table-based).
It has effect only on templates that use "{{ form }}" in the body. Only "Delete forms" now.
The setting is here to avoid RemovedInDjango50Warning.

More info:

Notes:

  • Remove this setting in Django 5.0 because DjangoDivFormRenderer will become deprecated and the same class will be used by default DjangoTemplates.
  • Discovered during debugging Move PYTHONWARNINGS to EnvVar #9503

Btw, there is no visual difference.

Before:
image

After:
image

@github-actions github-actions bot added the settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR label Mar 1, 2024
Copy link

dryrunsecurity bot commented Mar 1, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Sensitive Functions Analyzer 0 findings
Configured Sensitive Files Analyzer 0 findings
Sensitive Files Analyzer 1 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@kiblik kiblik force-pushed the use_DjangoDivFormRenderer branch from c9d65ee to 7ef4299 Compare March 1, 2024 08:46
@kiblik kiblik marked this pull request as ready for review March 1, 2024 08:57
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit ee1c6e0 into DefectDojo:dev Mar 4, 2024
122 checks passed
@kiblik kiblik deleted the use_DjangoDivFormRenderer branch March 27, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants