Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advance mobsf to also parse exisiting unittestfile #9563

Merged
merged 10 commits into from
Mar 1, 2024

Conversation

manuel-sommer
Copy link
Contributor

@manuel-sommer manuel-sommer commented Feb 16, 2024

This PR fixes this doing:

# TODO add more checks dedicated to this file

The unittestfile showed 0 vulnerabilities as the parser was not parsing it right.

Copy link

dryrunsecurity bot commented Feb 16, 2024

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
Sensitive Functions Analyzer
Configured Sensitive Files Analyzer
Sensitive Files Analyzer

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

@manuel-sommer
Copy link
Contributor Author

Also here, Kubernetes Deployment is failing...

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@manuel-sommer
Copy link
Contributor Author

Could we get this on the road for the next release upcomming Monday?
@grendel513 and @devGregA ?

@grendel513
Copy link
Contributor

Could we get this on the road for the next release upcomming Monday? @grendel513 and @devGregA ?

hi @manuel-sommer we truly appreciate your contributions, thank you. Can I kindly ask you to please refrain from requesting individuals review your PRs? As reviewers we have a very well defined process to organize, prioritize, review, approve and merge PRs. We would appreciate the room to follow our process to ensure all PRs are discussed, evaluated and tested for inclusion. Asking in this way may negatively affect the process, create rush and limit the time and effort on making sure each PR conforms to standards. Thank you in advance for your understanding.

@Maffooch Maffooch merged commit 86dfea3 into DefectDojo:dev Mar 1, 2024
121 of 122 checks passed
@manuel-sommer manuel-sommer deleted the advance_mobsf branch March 1, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants