Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release-drafter: Checkout to version #9231

Merged

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Dec 27, 2023

  • The test stack was built on top of the dev branch by default. It needs to be built from the version tag.
    • Wrong code was used, wrong tags have been placed to OpenAPI Speficications
  • Build of images is skipped, docker hub images are used (time save).

Before

image
$ curl -L https://github.com/DefectDojo/django-DefectDojo/releases/download/2.29.4/oas.yaml | head
info:
  title: Defect Dojo API v2
  version: 2.30.0-dev
  description: Defect Dojo - Open Source vulnerability Management made easy. Prefetch
    related parameters/responses not yet in the schema.
paths:
  /api/v2/api-token-auth/:
    post:
      operationId: api_token_auth_create

After

image ```

Copy link

dryrunsecurity bot commented Dec 27, 2023

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
AI-powered Sensitive Function Check
Configured Sensitive Files Check
AI-powered Sensitive Files Check

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

@kiblik kiblik force-pushed the release-drafter_checkout-to-version branch 2 times, most recently from bbac9e5 to 0216282 Compare January 1, 2024 11:33
@kiblik kiblik force-pushed the release-drafter_checkout-to-version branch from 0216282 to f1a14d7 Compare January 3, 2024 09:26
@kiblik kiblik changed the base branch from dev to bugfix January 3, 2024 09:26
@kiblik kiblik marked this pull request as ready for review January 3, 2024 09:27
Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this yesterday during the release, but did not dig into why building the containers was necessary. Very happy to see it is not :)

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit c8d6aed into DefectDojo:bugfix Jan 10, 2024
@kiblik kiblik deleted the release-drafter_checkout-to-version branch January 10, 2024 15:04
tomaszn pushed a commit to tomaszn/django-DefectDojo that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants