-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Django 4.x #7387
Migrate to Django 4.x #7387
Conversation
Please add to TODO list: |
@kiblik I do not think anything needs to change on the |
I check the note in the documentation and you are right. |
Okay thanks for confirming. Removing |
@kiblik Let me know the results of the remote user test whenever you are finished. Once that looks good, I think we are good to merge this to get as much dev testing in before the release as possible |
Tested. @Maffooch, https://github.com/Maffooch/django-DefectDojo/pull/5 |
Thank @kiblik you rock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Nice job handling the upgrade to 4.x - an before we were under the gun ;-)
Awesome work! glad we made it. |
Fixes #7385
Migration involved the following
Replace
django.utils.http.urlquote
withurllib.parse.quote
django 3.x deprecationsReplace
django.utils.encoding.force_text
withfrom django.utils.encoding.force_str
django 3.x deprecationsForked django-tagging as it needed Django 4 support. A PR was opened on 12/12/2021 to make the migration, but never received attention. We use this repository solely for migration 0066, and cannot remove the library. It is forked here with the changes required to install
Forked django-multiselectfield as it needed Django 4 support. Two PRs were opened (08/09/22022 and 12/01/2022), but neither received attention from someone who could merge. We use the library heavily, and alternatives are not readily available. It is forked here with the changes required to install and use.
Migration is a mystery to me. It is being auto created, but does not appear to break anything
https://github.com/DefectDojo/django-DefectDojo/blob/master/dojo/remote_user.py#L51 - I can check and test this part
https://github.com/DefectDojo/django-DefectDojo/blob/master/dojo/settings/settings.dist.py#L653