Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Django 4.x #7387

Merged
merged 9 commits into from
Jan 12, 2023
Merged

Migrate to Django 4.x #7387

merged 9 commits into from
Jan 12, 2023

Conversation

Maffooch
Copy link
Contributor

@Maffooch Maffooch commented Jan 9, 2023

Fixes #7385
Migration involved the following

@github-actions github-actions bot added the New Migration Adding a new migration file. Take care when merging. label Jan 9, 2023
@kiblik
Copy link
Contributor

kiblik commented Jan 9, 2023

Please add to TODO list:

@github-actions github-actions bot added docker settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR labels Jan 9, 2023
@Maffooch
Copy link
Contributor Author

@kiblik I do not think anything needs to change on the CSRF_TRUSTED_ORIGINS. Let me know if you agree/disagree

@Maffooch Maffooch marked this pull request as draft January 10, 2023 00:11
@kiblik
Copy link
Contributor

kiblik commented Jan 10, 2023

@kiblik I do not think anything needs to change on the CSRF_TRUSTED_ORIGINS. Let me know if you agree/disagree

I check the note in the documentation and you are right.
At least, that note in the file can be removed/updated.

@Maffooch
Copy link
Contributor Author

Okay thanks for confirming. Removing

@Maffooch Maffooch marked this pull request as ready for review January 10, 2023 02:57
@Maffooch
Copy link
Contributor Author

@kiblik Let me know the results of the remote user test whenever you are finished. Once that looks good, I think we are good to merge this to get as much dev testing in before the release as possible

@kiblik
Copy link
Contributor

kiblik commented Jan 11, 2023

Tested. @Maffooch, https://github.com/Maffooch/django-DefectDojo/pull/5
Mentioned lines could be removed without any impact on functionality.

@Maffooch
Copy link
Contributor Author

Thank @kiblik you rock

@Maffooch Maffooch requested review from devGregA and mtesauro January 11, 2023 20:53
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Nice job handling the upgrade to 4.x - an before we were under the gun ;-)

@devGregA devGregA merged commit 7eb8863 into DefectDojo:dev Jan 12, 2023
@Maffooch Maffooch deleted the sc-404 branch January 12, 2023 19:36
@damiencarol
Copy link
Contributor

damiencarol commented Jan 13, 2023

Awesome work! glad we made it.
we will need to work on removing github ref in the requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker maintenance New Migration Adding a new migration file. Take care when merging. settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants