-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jira issue type migration quickfix #11831
jira issue type migration quickfix #11831
Conversation
DryRun Security SummaryThe pull request updates database migration files and Docker test configurations but introduces several security concerns including exposed credentials, debug settings, and validation gaps in the Jira issue type configuration system. Expand for full summaryThis PR modifies database migration files for Jira issue type settings and updates Docker Compose configurations for unit testing. Security Findings:
Code AnalysisWe ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
* jira issue type migration quickfix * jira issue type migration quickfix: add env variable to unit test * jira issue type migration quickfix: add env variable to unit test
Fixes #11821 (for now the easy way).
A proper fix may take some time, this fix will allow users to add extra JIRA Issue Types again via
DD_JIRA_EXTRA_ISSUE_TYPES
Usually you shouldn't edit existing migration files. But in this case these "choices" have no effect on the actual database model. Django ORM doesn't propagate these choices to the database. It performs the validation in Python code.