Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aria-label in search box #11769

Merged

Conversation

kevin-vuong99
Copy link
Contributor

Description

The "Search" text area has no labels corresponding to it.
image

Accessibility Issue

[Impact on users] If a form control does not have a properly associated text label, the function or purpose of that form control may not be presented to screen reader users. Form labels also provide visible descriptions and larger clickable targets for form control.

[Steps to reproduce] While using the WAVE addon for FireFox, run it on the page and you will get this error.

Remediation

The aria-label had a typo which was fixed.

@github-actions github-actions bot added the ui label Feb 7, 2025
@kevin-vuong99 kevin-vuong99 marked this pull request as ready for review February 7, 2025 21:56
Copy link

dryrunsecurity bot commented Feb 7, 2025

DryRun Security Summary

The text describes a correction of the accessibility attribute from aria_label to aria-label in the base HTML template, which may indirectly enhance security through better accessibility standards.

Expand for full summary

Accessibility attribute correction made in dojo/templates/base.html, modifying aria-label attribute from aria_label to aria-label. Potential indirect security benefits through improved accessibility and consistent attribute naming. No direct security vulnerabilities identified.

Code Analysis

We ran 9 analyzers against 1 file and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Configured Codepaths Analyzer 1 finding

Overall Riskiness

🔴 Risk threshold exceeded.

We've notified @mtesauro, @grendel513.

View PR in the DryRun Dashboard.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit c4fe693 into DefectDojo:bugfix Feb 13, 2025
71 of 72 checks passed
quirinziessler pushed a commit to quirinziessler/django-DefectDojo that referenced this pull request Feb 18, 2025
Co-authored-by: Kevin Vuong <kevin.vuong@hrsdc-rhdcc.gc>
quirinziessler pushed a commit to quirinziessler/django-DefectDojo that referenced this pull request Feb 26, 2025
Co-authored-by: Kevin Vuong <kevin.vuong@hrsdc-rhdcc.gc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants