Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff: Merge safe rules (A, FIX, PLW01) #11750

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Feb 6, 2025

After many fixes, we can safely merge some rules without touching the code. I move FIX002 so we can merge all FIX rules.

Copy link

dryrunsecurity bot commented Feb 6, 2025

DryRun Security Summary

The PR updates Ruff's linting configuration by modifying rule selections and adding an FIX002 ignore rule, which may impact code quality monitoring despite no direct security concerns.

Expand for full summary

This PR modifies the Ruff linting configuration for Python code quality, adjusting rule selections and adding an ignore rule for FIX002. While no direct security vulnerabilities were found, the configuration changes include potential risk considerations: broadening rule selections may reduce code quality granularity, and ignoring the FIX002 rule could allow unaddressed TODO comments to persist, potentially indicating technical debt.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

@kiblik kiblik changed the title Ruff: Merge safe rules Ruff: Merge safe rules (A, FIX, PLW01) Feb 6, 2025
Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@mtesauro mtesauro merged commit 1b03d85 into DefectDojo:dev Feb 12, 2025
73 checks passed
@kiblik kiblik deleted the ruff/merge_safe branch February 12, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants