-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruff: Merge safe rules (A, FIX, PLW01) #11750
Conversation
DryRun Security SummaryThe PR updates Ruff's linting configuration by modifying rule selections and adding an FIX002 ignore rule, which may impact code quality monitoring despite no direct security concerns. Expand for full summaryThis PR modifies the Ruff linting configuration for Python code quality, adjusting rule selections and adding an ignore rule for FIX002. While no direct security vulnerabilities were found, the configuration changes include potential risk considerations: broadening rule selections may reduce code quality granularity, and ignoring the FIX002 rule could allow unaddressed TODO comments to persist, potentially indicating technical debt. Code AnalysisWe ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
c033f66
to
1ccefa4
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
1ccefa4
to
805651d
Compare
After many fixes, we can safely merge some rules without touching the code. I move
FIX002
so we can merge allFIX
rules.