Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): Label and group linters #11718

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Feb 2, 2025

Changes in the ruff.toml file indicated that some improvement connected to linters was performed. Why not label these PRs and group them in release notes? It increases the readability of notes.

Copy link

dryrunsecurity bot commented Feb 2, 2025

DryRun Security Summary

The text describes updates to GitHub Actions configuration files (.github/release-drafter.yml and .github/labeler.yml) that focus on improving code quality through linting and automated PR labeling, without direct security implications.

Expand for full summary

Summary:

The provided code changes are related to updates made to the GitHub Actions configuration files, specifically the .github/release-drafter.yml and .github/labeler.yml files. These changes do not directly introduce any security-related updates, but they do suggest a focus on improving the overall code quality and development practices of the project.

The changes to the .github/release-drafter.yml file introduce a new category for "Improved code quality with linters", which indicates that the project is placing importance on maintaining good code quality through the use of linters. Linters are tools that analyze source code to identify potential issues, including security vulnerabilities, which can indirectly contribute to the overall security posture of the application.

The changes to the .github/labeler.yml file are related to the automatic labeling of GitHub Pull Requests based on the files that have been modified. While this change does not have a direct impact on the security of the application, it can be a useful tool for organizing and categorizing changes, which can facilitate more effective code review and issue tracking.

Files Changed:

  1. .github/release-drafter.yml: This file was updated to include a new category for "Improved code quality with linters" with the label "lint". This change suggests a focus on maintaining good code quality through the use of linters, which can indirectly contribute to improved security.

  2. .github/labeler.yml: This file was updated to include a new section for "lint" with a single entry that applies the "lint" label to any changes made to the ruff.toml file. This change is related to the automatic labeling of GitHub Pull Requests and does not have a direct impact on the security of the application.

Code Analysis

We ran 9 analyzers against 2 files and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

@mtesauro
Copy link
Contributor

mtesauro commented Feb 3, 2025

This makes total sense - great call!

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit 2835b2e into DefectDojo:dev Feb 12, 2025
72 checks passed
@kiblik kiblik deleted the lint_label branch February 12, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants