Ruff: Add PLR5 and fix PLR5501

[kiblik]

Add PLR5* rules and fix collapsible-else-if (PLR5501)

[dryrunsecurity]

DryRun Security Summary

The pull request involves code refactoring across DefectDojo project files, with no critical security vulnerabilities introduced but containing potential security concerns around JIRA user creation, sensitive data handling, logging practices, and configuration dependencies that require careful management.

Expand for full summary

The pull request contains code refactoring across multiple files in the DefectDojo project, primarily simplifying conditional logic and reducing code complexity. Multiple files were modified with minor changes to improve code readability and structure.

Security Findings:

1. Hardcoded JIRA User Creation (dojo/jira_link/helper.py): Potential security concern with predictable system user creation with username "JIRA"
2. Sensitive Information Exposure: Multiple parsers handle vulnerability data with potential information sensitivity
3. Logging of Sensitive Details: Some files log detailed vulnerability information that could potentially expose sensitive data
4. Configuration Dependency: Several files rely on external settings that could introduce configuration management risks

No direct critical security vulnerabilities were introduced, but the code contains several areas that require careful configuration and management to prevent potential information exposure or unauthorized access.

Code Analysis

We ran 9 analyzers against 27 files and 2 analyzers had findings. 7 analyzers had no findings.

Analyzer	Findings
Authn/Authz Analyzer	4 findings
IDOR Analyzer	1 finding

Overall Riskiness

🟡 Please give this pull request extra attention during review.

View PR in the DryRun Dashboard.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[mtesauro]

Approved

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.