Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff: Add PLR02 and fix PLR0202 #11712

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Ruff: Add PLR02 and fix PLR0202 #11712

merged 1 commit into from
Feb 13, 2025

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Feb 2, 2025

Merge PLR02* rules and fix no-classmethod-decorator (PLR0202)

@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Feb 2, 2025 •
edited
Loading

DryRun Security Summary

The PR modifies Ruff linting configuration with potential minor security implications from test file ignore rules and preview mode, while also including a safe refactoring of MonthYearWidget's id_for_label method in dojo/forms.py.

Expand for full summary

PR updates Ruff configuration in ruff.toml and refactors MonthYearWidget's id_for_label method in dojo/forms.py. Security findings:

  1. In ruff.toml:
  • Potential security risk from per-file ignore rules in unit test files
  • Preview mode enabled could introduce experimental linting rules
  • Removal of PLR0203 and PLR0206 might slightly reduce code quality checks
  1. No direct vulnerabilities found in dojo/forms.py method modification.

Code Analysis

We ran 9 analyzers against 2 files and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

mtesauro
mtesauro approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the lint label Feb 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@mtesauro mtesauro merged commit 8a4a9eb into DefectDojo:dev Feb 13, 2025
73 checks passed
@kiblik kiblik deleted the ruff_PLR0202 branch February 13, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtesauro mtesauro mtesauro approved these changes

@dogboat dogboat dogboat approved these changes

@hblankenship hblankenship hblankenship approved these changes

@Maffooch Maffooch Maffooch approved these changes

Assignees
No one assigned
Labels
lint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kiblik @mtesauro @dogboat @hblankenship @Maffooch