-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(db-checker): Extension of "db reachable" #11651
Conversation
1cf37e0
to
3f36a4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
.github/workflows/k8s-tests.yml
Outdated
@@ -85,6 +85,7 @@ jobs: | |||
./helm/defectdojo \ | |||
--set django.ingress.enabled=true \ | |||
--set imagePullPolicy=Never \ | |||
--set initializer.keepSeconds="x" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this value intentional? Docs suggest this ttlSecondsAfterFinished
should be an integer - I'm not sure what it would do with a value of "x"?
ttlSecondsAfterFinished: {{ .Values.initializer.keepSeconds }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would be right if the value were passed to ttlSecondsAfterFinished
. However thanks to the previous line whole ttlSecondsAfterFinished
is dropped if you put their value other than a positive integer. This functionality was added in #11257
{{- if and (int .Values.initializer.keepSeconds) (gt (int .Values.initializer.keepSeconds) 0) }} |
I might change it to keep me
, 0
, -1
, ... or anything more descriptive here. I'm open to any recommendation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I should have read up one line! 😂 I think -1 is a pretty common pattern for "ignore this".
DryRun Security SummaryThe pull request implements comprehensive security and reliability improvements across DefectDojo's deployment and testing infrastructure, including secure configuration management, enhanced error handling, database connectivity checks, and secure deployment practices through updates to Docker entrypoint scripts, GitHub Actions workflows, and testing infrastructure. Expand for full summarySummary: The code changes in this pull request cover various aspects of the DefectDojo application's deployment and testing infrastructure, with a focus on improving the security and reliability of the application. The changes include updates to the Docker entrypoint scripts, GitHub Actions workflows, and unit test scripts. Key security-related improvements include:
While the changes generally demonstrate a security-conscious approach, it's important to continue reviewing the application's codebase, dependencies, and overall deployment configuration to ensure the ongoing security and integrity of the DefectDojo application. Files Changed:
Code AnalysisWe ran |
Reopen #10497
Extend
wait_for_database_to_be_reachable
. Not only for simple operation but check that DB is compatible.Added based on #10490
This PR also contains changes from #11650 because they are needed for proper testing of this functionality.