-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubescape: Reduce the size of steps to reproduce #11542
Conversation
maxi-bee
commented
Jan 10, 2025
•
edited
Loading
edited
- This is a change on the kubescape parser
- It removes the resource objects (a whole manifest) from "steps to reproduce" as it is often so long (thousands of lines) that conflicts with the default Jira configurations of maximum accepted length of fields, resulting on the failing to create a Jira ticket via the Defect Dojo integration
- Note that also, there is arguably little value on storing this very large objects on the database (for duplicate and original findings)
- Potentially, the Jira integration should validate that, but that isn't possibly the case
- removes the resource objects (a whole manifest) from "steps to reproduce" as it is often so long (thousands of lines) that conflicts with the default Jira configurations - potentially, the Jira integration should validate that, but that isn't possibly the case - note that also, there is arguably little value on storing this very large objects on the database (for duplicates and originals)
DryRun Security SummaryThe code change improves security by removing lines that could expose sensitive information in the Expand for full summarySummary: The provided code change is a security-focused improvement to the By removing these lines, the Files Changed:
Code AnalysisWe ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Hey folks. Once this is merged to dev when is this expected to hit a release? |
DefectDojo does minor releases every month that takes the dev branch and merges that to master/main. Those happen generally on the first Monday of the month. The releases between the minor releases are based on the bugfix branch and happen every Monday between minor releases. In the case of this PR, it will be released in 2.43.0 on Feb 3rd. |