Aqua: Update parser deduplication criteria 🐛

[manuel-sommer]

Updates the parser deduplication criteria to ensure that all findings of a given CPE are recorded within dojo

closes #10586

[dryrunsecurity]

DryRun Security Summary

The code changes in this pull request appear to be a reasonable improvement to the Aqua security scan parser in the dojo/tools/aqua/parser.py file, which helps to ensure that findings are uniquely identified based on the combination of the CPE (Common Platform Enumeration), the vulnerability name, and the resource path, and also includes a function to parse the output of an Aqua security scan and convert it into a list of Finding objects for the Django Vulnerability Engagement Tracker (DefectDojo) application.

Expand for full summary

Summary:

The code changes in this pull request appear to be a reasonable improvement to the Aqua security scan parser in the dojo/tools/aqua/parser.py file. The key change is the addition of the resource.get("path", "None") to the unique_key variable, which is used to identify unique findings. This change helps to ensure that findings are uniquely identified based on the combination of the CPE (Common Platform Enumeration), the vulnerability name, and the resource path. This is an important improvement, as it can help to prevent duplicate findings from being reported, which can improve the accuracy and usefulness of the security scan results.

Additionally, the get_items function in the file is responsible for parsing the output of an Aqua security scan and converting it into a list of Finding objects, which can be used by the Django Vulnerability Engagement Tracker (DefectDojo) application. This is a common task for an application security engineer, as they often need to integrate various security tools and services into their organization's security workflows. Overall, the code changes seem to be a reasonable improvement to the Aqua security scan parser, and there don't appear to be any obvious security concerns in the provided code.

Files Changed:

• dojo/tools/aqua/parser.py: The key change in this file is the addition of the resource.get("path", "None") to the unique_key variable, which is used to identify unique findings. This change helps to ensure that findings are uniquely identified based on the combination of the CPE (Common Platform Enumeration), the vulnerability name, and the resource path. The get_items function in this file is responsible for parsing the output of an Aqua security scan and converting it into a list of Finding objects, which can be used by the Django Vulnerability Engagement Tracker (DefectDojo) application.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

[mtesauro]

Approved