-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entrypoint Scripts: Add container level breakouts to prevent doom loopings #10374
Conversation
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Change Summary (click to expand)The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective. Summary: The code changes in this pull request are focused on improving the reliability, stability, and security of the various workflows and Docker-based components used in the DefectDojo application. The changes include the addition of timeout mechanisms, database connection checks, error handling, and other security-related enhancements across multiple files and scripts. Some key security-related changes include:
Overall, the code changes in this pull request appear to be focused on improving the overall security and reliability of the DefectDojo application, which is a positive step for the project's security posture. Files Changed:
Powered by DryRun Security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Thanks for putting some great guardrails on our GH Actions 🚀 |
In cases where the
settings.dist.py
hash is incorrect in incoming PRs, containers will boot loop during unit tests until they timeout. By default this timeout is 360 minutes, or 6 hours. This prevents units tests from actually running for all other PRsThis PR adds a breakout condition after 10 seconds of not being able to query the database through Django's
db_shell
to allow unit tests to exit quicker. In addition, I also added some timeouts for GHA action jobs just in case we run into a similar situation down the road[sc-6360]