Skip to content

Commit

Permalink
🐛 Fix RedHatSatellite components (#10082)
Browse files Browse the repository at this point in the history
  • Loading branch information
@manuel-sommer
manuel-sommer authored May 3, 2024
1 parent 227d069 commit 425ec14
Show file tree
Hide file tree
Showing 3 changed files with 266 additions and 1 deletion.
2 changes: 1 addition & 1 deletion dojo/tools/redhatsatellite/parser.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,13 @@ def get_findings(self, filename, test):
description += "**installable:** " + str(installable) + "\n"
description += "**bugs:** " + str(bugs) + "\n"
description += "**module_streams:** " + str(module_streams) + "\n"
description += "**packages:** " + ', '.join(packages)
find = Finding(
title=title,
test=test,
description=description,
severity=self.severity_mapping(input=severity),
mitigation=solution,
component_name=packages,
dynamic_finding=True,
)
if errata_id is not None:
Expand Down
258 changes: 258 additions & 0 deletions unittests/scans/redhatsatellite/many_packages.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,258 @@
{
"total": 24,
"subtotal": 24,
"selectable": 24,
"page": "1",
"per_page": "100",
"error": null,
"search": null,
"sort": {
"by": "updated",
"order": "desc"
},
"results": [
{
"id": 1234,
"pulp_id": "RHBA-1999:5678",
"title": "glibc bug fix update",
"errata_id": "RHBA-1999:5678",
"issued": "1999-03-05",
"updated": "1999-03-05",
"severity": "None",
"description": "description",
"solution": "solution",
"summary": "summary",
"reboot_suggested": true,
"uuid": "RHBA-1999:5678",
"name": "bug fix update",
"type": "bugfix",
"cves": [],
"bugs": [],
"hosts_available_count": 9,
"hosts_applicable_count": 9,
"packages": [
"asdf-123456.i111",
"asdf-123456.99_11",
"asdf-asdf-fjewios-123456.99_11",
"asdf-asdf-123456.99_11",
"asdf-asdf-123456.99_11",
"asdf-asdf-123456.i111",
"asdf-asdf-123456.99_11",
"asdf-asdf-123456.asdf",
"asdf-asdf-asdf-123456.i111",
"asdf-asdf-asdf-123456.99_11",
"asdf-asdf-123456.99_11",
"asdf-fjewio-aa-123456.99_11",
"asdf-fjewio-af-123456.99_11",
"asdf-fjewio-agr-123456.99_11",
"asdf-fjewio-ak-123456.99_11",
"asdf-fjewio-am-123456.99_11",
"asdf-fjewio-an-123456.99_11",
"asdf-fjewio-anp-123456.99_11",
"asdf-fjewio-ar-123456.99_11",
"asdf-fjewio-as-123456.99_11",
"asdf-fjewio-ast-123456.99_11",
"asdf-fjewio-ayc-123456.99_11",
"asdf-fjewio-az-123456.99_11",
"asdf-fjewio-be-123456.99_11",
"asdf-fjewio-bem-123456.99_11",
"asdf-fjewio-ber-123456.99_11",
"asdf-fjewio-bg-123456.99_11",
"asdf-fjewio-bhb-123456.99_11",
"asdf-fjewio-bho-123456.99_11",
"asdf-fjewio-bi-123456.99_11",
"asdf-fjewio-bn-123456.99_11",
"asdf-fjewio-bo-123456.99_11",
"asdf-fjewio-br-123456.99_11",
"asdf-fjewio-brx-123456.99_11",
"asdf-fjewio-bs-123456.99_11",
"asdf-fjewio-byn-123456.99_11",
"asdf-fjewio-ca-123456.99_11",
"asdf-fjewio-ce-123456.99_11",
"asdf-fjewio-chr-123456.99_11",
"asdf-fjewio-ckb-123456.99_11",
"asdf-fjewio-cmn-123456.99_11",
"asdf-fjewio-crh-123456.99_11",
"asdf-fjewio-cs-123456.99_11",
"asdf-fjewio-csb-123456.99_11",
"asdf-fjewio-cv-123456.99_11",
"asdf-fjewio-cy-123456.99_11",
"asdf-fjewio-da-123456.99_11",
"asdf-fjewio-de-123456.99_11",
"asdf-fjewio-doi-123456.99_11",
"asdf-fjewio-dsb-123456.99_11",
"asdf-fjewio-dv-123456.99_11",
"asdf-fjewio-dz-123456.99_11",
"asdf-fjewio-el-123456.99_11",
"asdf-fjewio-en-123456.99_11",
"asdf-fjewio-eo-123456.99_11",
"asdf-fjewio-es-123456.99_11",
"asdf-fjewio-et-123456.99_11",
"asdf-fjewio-eu-123456.99_11",
"asdf-fjewio-fa-123456.99_11",
"asdf-fjewio-ff-123456.99_11",
"asdf-fjewio-fi-123456.99_11",
"asdf-fjewio-fil-123456.99_11",
"asdf-fjewio-fo-123456.99_11",
"asdf-fjewio-fr-123456.99_11",
"asdf-fjewio-fur-123456.99_11",
"asdf-fjewio-fy-123456.99_11",
"asdf-fjewio-ga-123456.99_11",
"asdf-fjewio-gd-123456.99_11",
"asdf-fjewio-gez-123456.99_11",
"asdf-fjewio-gl-123456.99_11",
"asdf-fjewio-gu-123456.99_11",
"asdf-fjewio-gv-123456.99_11",
"asdf-fjewio-ha-123456.99_11",
"asdf-fjewio-hak-123456.99_11",
"asdf-fjewio-he-123456.99_11",
"asdf-fjewio-hi-123456.99_11",
"asdf-fjewio-hif-123456.99_11",
"asdf-fjewio-hne-123456.99_11",
"asdf-fjewio-hr-123456.99_11",
"asdf-fjewio-hsb-123456.99_11",
"asdf-fjewio-ht-123456.99_11",
"asdf-fjewio-hu-123456.99_11",
"asdf-fjewio-hy-123456.99_11",
"asdf-fjewio-ia-123456.99_11",
"asdf-fjewio-id-123456.99_11",
"asdf-fjewio-ig-123456.99_11",
"asdf-fjewio-ik-123456.99_11",
"asdf-fjewio-is-123456.99_11",
"asdf-fjewio-it-123456.99_11",
"asdf-fjewio-iu-123456.99_11",
"asdf-fjewio-ja-123456.99_11",
"asdf-fjewio-ka-123456.99_11",
"asdf-fjewio-kab-123456.99_11",
"asdf-fjewio-kk-123456.99_11",
"asdf-fjewio-kl-123456.99_11",
"asdf-fjewio-km-123456.99_11",
"asdf-fjewio-kn-123456.99_11",
"asdf-fjewio-ko-123456.99_11",
"asdf-fjewio-kok-123456.99_11",
"asdf-fjewio-ks-123456.99_11",
"asdf-fjewio-ku-123456.99_11",
"asdf-fjewio-kw-123456.99_11",
"asdf-fjewio-ky-123456.99_11",
"asdf-fjewio-lb-123456.99_11",
"asdf-fjewio-lg-123456.99_11",
"asdf-fjewio-li-123456.99_11",
"asdf-fjewio-lij-123456.99_11",
"asdf-fjewio-ln-123456.99_11",
"asdf-fjewio-lo-123456.99_11",
"asdf-fjewio-lt-123456.99_11",
"asdf-fjewio-lv-123456.99_11",
"asdf-fjewio-lzh-123456.99_11",
"asdf-fjewio-mag-123456.99_11",
"asdf-fjewio-mai-123456.99_11",
"asdf-fjewio-mfe-123456.99_11",
"asdf-fjewio-mg-123456.99_11",
"asdf-fjewio-mhr-123456.99_11",
"asdf-fjewio-mi-123456.99_11",
"asdf-fjewio-miq-123456.99_11",
"asdf-fjewio-mjw-123456.99_11",
"asdf-fjewio-mk-123456.99_11",
"asdf-fjewio-ml-123456.99_11",
"asdf-fjewio-mn-123456.99_11",
"asdf-fjewio-mni-123456.99_11",
"asdf-fjewio-mnw-123456.99_11",
"asdf-fjewio-mr-123456.99_11",
"asdf-fjewio-ms-123456.99_11",
"asdf-fjewio-mt-123456.99_11",
"asdf-fjewio-my-123456.99_11",
"asdf-fjewio-nan-123456.99_11",
"asdf-fjewio-nb-123456.99_11",
"asdf-fjewio-nds-123456.99_11",
"asdf-fjewio-ne-123456.99_11",
"asdf-fjewio-nhn-123456.99_11",
"asdf-fjewio-niu-123456.99_11",
"asdf-fjewio-nl-123456.99_11",
"asdf-fjewio-nn-123456.99_11",
"asdf-fjewio-nr-123456.99_11",
"asdf-fjewio-nso-123456.99_11",
"asdf-fjewio-oc-123456.99_11",
"asdf-fjewio-om-123456.99_11",
"asdf-fjewio-or-123456.99_11",
"asdf-fjewio-os-123456.99_11",
"asdf-fjewio-pa-123456.99_11",
"asdf-fjewio-pap-123456.99_11",
"asdf-fjewio-pl-123456.99_11",
"asdf-fjewio-ps-123456.99_11",
"asdf-fjewio-pt-123456.99_11",
"asdf-fjewio-quz-123456.99_11",
"asdf-fjewio-raj-123456.99_11",
"asdf-fjewio-ro-123456.99_11",
"asdf-fjewio-ru-123456.99_11",
"asdf-fjewio-rw-123456.99_11",
"asdf-fjewio-sa-123456.99_11",
"asdf-fjewio-sah-123456.99_11",
"asdf-fjewio-sat-123456.99_11",
"asdf-fjewio-sc-123456.99_11",
"asdf-fjewio-sd-123456.99_11",
"asdf-fjewio-se-123456.99_11",
"asdf-fjewio-sgs-123456.99_11",
"asdf-fjewio-shn-123456.99_11",
"asdf-fjewio-shs-123456.99_11",
"asdf-fjewio-si-123456.99_11",
"asdf-fjewio-sid-123456.99_11",
"asdf-fjewio-sk-123456.99_11",
"asdf-fjewio-sl-123456.99_11",
"asdf-fjewio-sm-123456.99_11",
"asdf-fjewio-so-123456.99_11",
"asdf-fjewio-sq-123456.99_11",
"asdf-fjewio-sr-123456.99_11",
"asdf-fjewio-ss-123456.99_11",
"asdf-fjewio-st-123456.99_11",
"asdf-fjewio-sv-123456.99_11",
"asdf-fjewio-sw-123456.99_11",
"asdf-fjewio-szl-123456.99_11",
"asdf-fjewio-ta-123456.99_11",
"asdf-fjewio-tcy-123456.99_11",
"asdf-fjewio-te-123456.99_11",
"asdf-fjewio-tg-123456.99_11",
"asdf-fjewio-th-123456.99_11",
"asdf-fjewio-the-123456.99_11",
"asdf-fjewio-ti-123456.99_11",
"asdf-fjewio-tig-123456.99_11",
"asdf-fjewio-tk-123456.99_11",
"asdf-fjewio-tl-123456.99_11",
"asdf-fjewio-tn-123456.99_11",
"asdf-fjewio-to-123456.99_11",
"asdf-fjewio-tpi-123456.99_11",
"asdf-fjewio-tr-123456.99_11",
"asdf-fjewio-ts-123456.99_11",
"asdf-fjewio-tt-123456.99_11",
"asdf-fjewio-ug-123456.99_11",
"asdf-fjewio-uk-123456.99_11",
"asdf-fjewio-unm-123456.99_11",
"asdf-fjewio-ur-123456.99_11",
"asdf-fjewio-uz-123456.99_11",
"asdf-fjewio-ve-123456.99_11",
"asdf-fjewio-vi-123456.99_11",
"asdf-fjewio-wa-123456.99_11",
"asdf-fjewio-wae-123456.99_11",
"asdf-fjewio-wal-123456.99_11",
"asdf-fjewio-wo-123456.99_11",
"asdf-fjewio-xh-123456.99_11",
"asdf-fjewio-yi-123456.99_11",
"asdf-fjewio-yo-123456.99_11",
"asdf-fjewio-yue-123456.99_11",
"asdf-fjewio-yuw-123456.99_11",
"asdf-fjewio-zh-123456.99_11",
"asdf-fjewio-zu-123456.99_11",
"asdf-locale-source-123456.99_11",
"asdf-asdf-fjewio-123456.99_11",
"asdf-asdf-123456.i111",
"asdf-asdf-123456.99_11",
"asdf--123456.i111",
"asdf--123456.99_11",
"asdf-123456.99_11",
"asfd-123456.i111",
"asdf-123456.99_11",
"asdf-123456.99_11"
],
"module_streams": [],
"installable": true
}
]
}
7 changes: 7 additions & 0 deletions unittests/tools/test_redhatsatellite_parser.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,10 @@ def test_parse_file_with_multiple_findingse(self):
self.assertEqual("RHSA-1966:12313", findings[0].unsaved_vulnerability_ids[0])
self.assertEqual("CVE-1990-1", findings[0].unsaved_vulnerability_ids[1])
self.assertEqual("CVE-1990-2", findings[0].unsaved_vulnerability_ids[2])

def test_parse_file_with_many_packages(self):
with open("unittests/scans/redhatsatellite/many_packages.json") as testfile:
parser = RedHatSatelliteParser()
findings = parser.get_findings(testfile, Test())
self.assertEqual(1, len(findings))
self.assertEqual("RHBA-1999:5678", findings[0].unsaved_vulnerability_ids[0])

0 comments on commit 425ec14

Please sign in to comment.