allow selection escape with escape button #178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When navigating the result selection via keyboard, pressing Escape will now let users close the result list. The focus will then be in the same place as if the result list was closed due to an actual selection.
I'm rather unhappy with the solution as, in Fullscreen mode, the plugin will take precedence and use the escape signal first, stopping its progression. Also, I couldn't make the
clear
button available, since that is a bug fixed in vuetify@3, where migration is not trivial, and it seems they only adressed that in the next major version. If you care:Hence, this minimal and IMO okayish solution. At least everything can be done via keyboard, even if not in an ideal fashion.
Instructions for local reproduction and review
Check all clients with AddressSearch.
Relevant tickets, issues, et cetera
Resolves #110