Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow selection escape with escape button #178

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

warm-coolguy
Copy link
Member

Summary

When navigating the result selection via keyboard, pressing Escape will now let users close the result list. The focus will then be in the same place as if the result list was closed due to an actual selection.

I'm rather unhappy with the solution as, in Fullscreen mode, the plugin will take precedence and use the escape signal first, stopping its progression. Also, I couldn't make the clear button available, since that is a bug fixed in vuetify@3, where migration is not trivial, and it seems they only adressed that in the next major version. If you care:

Hence, this minimal and IMO okayish solution. At least everything can be done via keyboard, even if not in an ideal fashion.

Instructions for local reproduction and review

Check all clients with AddressSearch.

Relevant tickets, issues, et cetera

Resolves #110

@warm-coolguy warm-coolguy added the enhancement New feature or request label Sep 16, 2024
@warm-coolguy warm-coolguy self-assigned this Sep 16, 2024
Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dopenguin dopenguin merged commit 161e486 into main Sep 23, 2024
3 checks passed
@dopenguin dopenguin deleted the fix-#110/escape-selection branch September 23, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close address search on Esc press
2 participants