Add support for extracting datadog tags from metric by RegExp #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR can also be used to achieve the same feature as in #7 |
|
Also, I tried to be consistent with the style of the rest of the code - even though it can be improved. However, this is out of the scope of this PR. |
oryband
force-pushed
the
metric-parts-to-tags
branch
from
fac79a0 to
d9aaa3a
Compare
|
Updated the regexps to be more precise |
oryband
force-pushed
the
metric-parts-to-tags
branch
from
d9aaa3a to
2ba47cb
Compare
Add 'datadogMetricTagsByRegExp' configuration,
which receives an object of { RegExpString: [TagNameString1, TagNameString2] }
where each tag name corresponds to a capture group in the regular expression.
For example:
datadogMetricTagsByRegExp: {
'^interface\\.(\\S+)\\.(?:if_packets\\.packets|if_octets\\.octets|if_errors\\.errors)\\.(?:rx|tx)$': ['interface_name'],
'^cpu\\.(\\d+)\\.cpu\\.(user|system|wait|idle|steal|nice|interrupt|softirq)$': ['cpu_cpu', 'cpu_time'],
'^tcpconns\\.(\\S+)\\.tcp_connections\\.(ESTABLISHED|SYN_SENT|SYN_RECV|FIN_WAIT1|FIN_WAIT2|TIME_WAIT|CLOSED|CLOSED_WAIT|LAST_ACK|LISTEN|CLOSING)$': ['tcpconns_port', 'tcpconns_state'],
'^load\\.load\\.(shortterm|midterm|longterm)$': ['load_term'],
'^memory\\.memory\\.(cached|buffered|free|slab_recl|slab_unrecl|used)$': ['memory_type'],
'^df\\.(\\S+)+\\.df_complex\\.(free|reserved|used)$': ['df_partition', 'df_type'],
}
NOTE the strings will be read as a RegExp object, thus backslashes must be escaped.
The captured groups will be extracted and removed from the metric name and be
reported as datadog tags along with the metric e.g.
'interface.br-e5f9ab1037e7.if_packets.packets.tx' will be transformed into
'interface.if_packets.packets.tx|#interface_name:br-e5f9ab1037e7'
This allows for adding tag dimensions to untagged (e.g. collectd) metrics.
oryband
force-pushed
the
metric-parts-to-tags
branch
from
2ba47cb to
5fe2a23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
datadogMetricTagsByRegExpconfiguration,which receives an object of
{ RegExpString: [TagNameString1, TagNameString2] }where each tag name corresponds to a capture group in the regular expression.
For example:
NOTE the strings will be read as a RegExp object, thus backslashes must be escaped.
The captured groups will be extracted and removed from the metric name and be
reported as datadog tags along with the metric e.g.
'interface.br-e5f9ab1037e7.if_packets.packets.tx'will be transformed into'interface.if_packets.packets.tx|#interface_name:br-e5f9ab1037e7'This allows for adding tag dimensions to untagged (e.g. collectd) metrics.