Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Harmonize timeouts #317

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

prognant
Copy link
Contributor

@prognant prognant commented Aug 31, 2020

Harmonize timeouts for connection & reconnection events :

In both cases tasks classes (InstanceInitializingTask ) are the same, so we can end up with timeout happening in one case and not the other, leading to inconsistent behaviour between the initial connection and the subsequent ones (if any).

Note: the reconnection timeout is also used when InstanceCleanupTask are triggered, that why I suggest not to remove it (for the moment).

@prognant prognant merged commit 271bbeb into master Sep 3, 2020
@prognant prognant deleted the prognant/harmonise-connection-timeout branch September 18, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants