Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] 0.36.1 changelog #290

Merged
merged 1 commit into from
Apr 2, 2020
Merged

[release] 0.36.1 changelog #290

merged 1 commit into from
Apr 2, 2020

Conversation

prognant
Copy link
Contributor

@prognant prognant commented Apr 2, 2020

No description provided.

@prognant prognant added this to the 0.36.1 milestone Apr 2, 2020
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, can you fix the markdown formatting of the PR URLs as well?

Feel free to merge once addressed 👍

CHANGELOG.md Outdated
### Changes
* [IMPROVEMENT] Connection timeout is now configurable [#289][]
* [IMPROVEMENT] Fix json service check status [#287][]
* [BUGFIX] Revert pull request [#285][] [#288][]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: what's the user impact of this revert + PR #289? (might be worth merging the 2 items into 1 for clarity)

@prognant prognant merged commit a05c365 into master Apr 2, 2020
@prognant prognant deleted the prognant/release branch April 2, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants