Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Khang.truong/change no data #19718

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

khangtruong
Copy link

What does this PR do?

This PR changes the monitors to adopt the new No Data behaviour since the old one is deprecated.

Motivation

Monitors won't work with the old option

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@khangtruong
Copy link
Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 12, 2025

View all feedbacks in Devflow UI.
2025-03-12 10:18:43 UTC ℹ️ Start processing command /merge


2025-03-12 10:18:48 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-12 14:19:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants