net/tcp: Add poll_accept, poll_shared_accept and poll_shutdown #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HippoBaro
approved these changes
Feb 26, 2022
Comment on lines
+603
to
+606
| match ready!(self.stream.poll_shutdown(cx, how)) { | ||
| Ok(()) => Poll::Ready(Ok(())), | ||
| Err(err) => Poll::Ready(Err(err.into())), | ||
| } |
There was a problem hiding this comment.
Suggested change
| match ready!(self.stream.poll_shutdown(cx, how)) { | |
| Ok(()) => Poll::Ready(Ok(())), | |
| Err(err) => Poll::Ready(Err(err.into())), | |
| } | |
| ready!(self.stream.poll_shutdown(cx, how)).map_err(Into::into) |
Comment on lines
233
to
234
| Ok(a.bind_to_executor()) | ||
| } |
There was a problem hiding this comment.
I think we should use poll_fn here like elsewhere for the sake of consistency
HippoBaro
force-pushed
the
master
branch
2 times, most recently
from
616409a to
d480c63
Compare
|
Is this PR dead? I'm in need of a non-blocking way to accept connections on a |
|
@glommer this seems fine to merge (I don't need it but just working through the backlog). There's an outstanding nit where the poll_shutdown isn't as absolutely concise as it could be (neither is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
TcpListener::poll_accept,TcpListener::poll_shared_acceptandTcpStream::poll_shutdownand internally adds
poll_collect_rw.Motivation
The main methods I need right now for #531.