Enable telemetry logs for services using AppSec #7534

smola · 2024-08-30T12:37:25Z

What Does This Do

Default telemetry logs to enabled for services with DD_APPSEC_ENABLED=true.

Motivation

As we rollout Exploit Prevention, we'd like to be sure to catch any unexpected error.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
~~[ ] Update the public documentation in case of new configuration flag or behavior~~

pr-commenter · 2024-08-30T13:34:40Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/telemetry-logs-for-appsec
git_commit_date	1725019352	1725022192
git_commit_sha	`6025023`	`7865c85`
release_version	1.39.0-SNAPSHOT~6025023dd6	1.39.0-SNAPSHOT~7865c85a8d

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1725024619	1725024619
ci_job_id	622867732	622867732
ci_pipeline_id	43250336	43250336
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~7865c85a8d, baseline=1.39.0-SNAPSHOT~6025023dd6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050495
Total [baseline] (8.487 s) : 0, 8486880
Agent [candidate] (1.049 s) : 0, 1048760
Total [candidate] (8.496 s) : 0, 8495622
section iast
Agent [baseline] (1.18 s) : 0, 1180253
Total [baseline] (8.951 s) : 0, 8951042
Agent [candidate] (1.172 s) : 0, 1172210
Total [candidate] (8.941 s) : 0, 8940615
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1181856
Total [baseline] (8.92 s) : 0, 8920341
Agent [candidate] (1.175 s) : 0, 1175286
Total [candidate] (8.949 s) : 0, 8948546
section iast_TELEMETRY_OFF
Agent [baseline] (1.179 s) : 0, 1178614
Total [baseline] (9.008 s) : 0, 9008463
Agent [candidate] (1.18 s) : 0, 1179923
Total [candidate] (8.944 s) : 0, 8943592

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.18 s	129.758 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.182 s	131.361 ms (12.5%)
Agent	iast_TELEMETRY_OFF	1.179 s	128.119 ms (12.2%)
Total	tracing	8.487 s	-
Total	iast	8.951 s	464.163 ms (5.5%)
Total	iast_HARDCODED_SECRET_DISABLED	8.92 s	433.461 ms (5.1%)
Total	iast_TELEMETRY_OFF	9.008 s	521.584 ms (6.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	iast	1.172 s	123.45 ms (11.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.175 s	126.526 ms (12.1%)
Agent	iast_TELEMETRY_OFF	1.18 s	131.163 ms (12.5%)
Total	tracing	8.496 s	-
Total	iast	8.941 s	444.994 ms (5.2%)
Total	iast_HARDCODED_SECRET_DISABLED	8.949 s	452.924 ms (5.3%)
Total	iast_TELEMETRY_OFF	8.944 s	447.97 ms (5.3%)

gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~7865c85a8d, baseline=1.39.0-SNAPSHOT~6025023dd6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.333 ms) : 0, 670333
BytebuddyAgent [candidate] (669.007 ms) : 0, 669007
GlobalTracer [baseline] (307.053 ms) : 0, 307053
GlobalTracer [candidate] (306.494 ms) : 0, 306494
AppSec [baseline] (51.358 ms) : 0, 51358
AppSec [candidate] (51.525 ms) : 0, 51525
Remote Config [baseline] (670.1 µs) : 0, 670
Remote Config [candidate] (668.677 µs) : 0, 669
Telemetry [baseline] (7.451 ms) : 0, 7451
Telemetry [candidate] (7.476 ms) : 0, 7476
section iast
BytebuddyAgent [baseline] (784.871 ms) : 0, 784871
BytebuddyAgent [candidate] (779.109 ms) : 0, 779109
GlobalTracer [baseline] (297.309 ms) : 0, 297309
GlobalTracer [candidate] (294.985 ms) : 0, 294985
AppSec [baseline] (53.773 ms) : 0, 53773
AppSec [candidate] (51.365 ms) : 0, 51365
IAST [baseline] (22.674 ms) : 0, 22674
IAST [candidate] (24.439 ms) : 0, 24439
Remote Config [baseline] (580.182 µs) : 0, 580
Remote Config [candidate] (599.93 µs) : 0, 600
Telemetry [baseline] (7.327 ms) : 0, 7327
Telemetry [candidate] (8.082 ms) : 0, 8082
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (785.405 ms) : 0, 785405
BytebuddyAgent [candidate] (780.448 ms) : 0, 780448
GlobalTracer [baseline] (298.015 ms) : 0, 298015
GlobalTracer [candidate] (296.65 ms) : 0, 296650
AppSec [baseline] (53.918 ms) : 0, 53918
AppSec [candidate] (52.132 ms) : 0, 52132
IAST [baseline] (22.805 ms) : 0, 22805
IAST [candidate] (23.622 ms) : 0, 23622
Remote Config [baseline] (590.283 µs) : 0, 590
Remote Config [candidate] (591.003 µs) : 0, 591
Telemetry [baseline] (7.414 ms) : 0, 7414
Telemetry [candidate] (8.162 ms) : 0, 8162
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (783.449 ms) : 0, 783449
BytebuddyAgent [candidate] (784.333 ms) : 0, 784333
GlobalTracer [baseline] (298.106 ms) : 0, 298106
GlobalTracer [candidate] (298.044 ms) : 0, 298044
AppSec [baseline] (53.983 ms) : 0, 53983
AppSec [candidate] (54.412 ms) : 0, 54412
IAST [baseline] (21.567 ms) : 0, 21567
IAST [candidate] (21.612 ms) : 0, 21612
Remote Config [baseline] (576.308 µs) : 0, 576
Remote Config [candidate] (570.216 µs) : 0, 570
Telemetry [baseline] (7.2 ms) : 0, 7200
Telemetry [candidate] (7.151 ms) : 0, 7151

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~7865c85a8d, baseline=1.39.0-SNAPSHOT~6025023dd6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048669
Total [baseline] (10.353 s) : 0, 10352842
Agent [candidate] (1.057 s) : 0, 1056913
Total [candidate] (10.392 s) : 0, 10391873
section appsec
Agent [baseline] (1.188 s) : 0, 1187975
Total [baseline] (10.566 s) : 0, 10565550
Agent [candidate] (1.179 s) : 0, 1178707
Total [candidate] (10.611 s) : 0, 10610567
section iast
Agent [baseline] (1.177 s) : 0, 1176972
Total [baseline] (10.83 s) : 0, 10829644
Agent [candidate] (1.172 s) : 0, 1172422
Total [candidate] (10.753 s) : 0, 10753338
section profiling
Agent [baseline] (1.245 s) : 0, 1245211
Total [baseline] (10.609 s) : 0, 10609142
Agent [candidate] (1.246 s) : 0, 1245578
Total [candidate] (10.606 s) : 0, 10606384

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	appsec	1.188 s	139.306 ms (13.3%)
Agent	iast	1.177 s	128.303 ms (12.2%)
Agent	profiling	1.245 s	196.542 ms (18.7%)
Total	tracing	10.353 s	-
Total	appsec	10.566 s	212.708 ms (2.1%)
Total	iast	10.83 s	476.803 ms (4.6%)
Total	profiling	10.609 s	256.3 ms (2.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	appsec	1.179 s	121.794 ms (11.5%)
Agent	iast	1.172 s	115.509 ms (10.9%)
Agent	profiling	1.246 s	188.665 ms (17.9%)
Total	tracing	10.392 s	-
Total	appsec	10.611 s	218.694 ms (2.1%)
Total	iast	10.753 s	361.465 ms (3.5%)
Total	profiling	10.606 s	214.511 ms (2.1%)

gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~7865c85a8d, baseline=1.39.0-SNAPSHOT~6025023dd6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.132 ms) : 0, 669132
BytebuddyAgent [candidate] (674.495 ms) : 0, 674495
GlobalTracer [baseline] (306.6 ms) : 0, 306600
GlobalTracer [candidate] (308.548 ms) : 0, 308548
AppSec [baseline] (51.248 ms) : 0, 51248
AppSec [candidate] (51.934 ms) : 0, 51934
Remote Config [baseline] (667.837 µs) : 0, 668
Remote Config [candidate] (672.867 µs) : 0, 673
Telemetry [baseline] (7.458 ms) : 0, 7458
Telemetry [candidate] (7.563 ms) : 0, 7563
section appsec
BytebuddyAgent [baseline] (692.684 ms) : 0, 692684
BytebuddyAgent [candidate] (686.835 ms) : 0, 686835
GlobalTracer [baseline] (302.47 ms) : 0, 302470
GlobalTracer [candidate] (299.691 ms) : 0, 299691
AppSec [baseline] (159.48 ms) : 0, 159480
AppSec [candidate] (158.825 ms) : 0, 158825
IAST [baseline] (21.03 ms) : 0, 21030
IAST [candidate] (19.217 ms) : 0, 19217
Remote Config [baseline] (615.831 µs) : 0, 616
Remote Config [candidate] (613.008 µs) : 0, 613
Telemetry [baseline] (8.541 ms) : 0, 8541
Telemetry [candidate] (9.585 ms) : 0, 9585
section iast
BytebuddyAgent [baseline] (784.062 ms) : 0, 784062
BytebuddyAgent [candidate] (779.116 ms) : 0, 779116
GlobalTracer [baseline] (295.337 ms) : 0, 295337
GlobalTracer [candidate] (295.61 ms) : 0, 295610
AppSec [baseline] (52.945 ms) : 0, 52945
AppSec [candidate] (51.802 ms) : 0, 51802
IAST [baseline] (23.085 ms) : 0, 23085
IAST [candidate] (23.6 ms) : 0, 23600
Remote Config [baseline] (580.591 µs) : 0, 581
Remote Config [candidate] (595.267 µs) : 0, 595
Telemetry [baseline] (7.288 ms) : 0, 7288
Telemetry [candidate] (8.106 ms) : 0, 8106
section profiling
BytebuddyAgent [baseline] (662.701 ms) : 0, 662701
BytebuddyAgent [candidate] (663.537 ms) : 0, 663537
GlobalTracer [baseline] (389.091 ms) : 0, 389091
GlobalTracer [candidate] (388.587 ms) : 0, 388587
AppSec [baseline] (51.912 ms) : 0, 51912
AppSec [candidate] (51.887 ms) : 0, 51887
Remote Config [baseline] (676.932 µs) : 0, 677
Remote Config [candidate] (679.44 µs) : 0, 679
Telemetry [baseline] (7.349 ms) : 0, 7349
Telemetry [candidate] (7.344 ms) : 0, 7344
ProfilingAgent [baseline] (95.767 ms) : 0, 95767
ProfilingAgent [candidate] (95.659 ms) : 0, 95659
Profiling [baseline] (95.79 ms) : 0, 95790
Profiling [candidate] (95.684 ms) : 0, 95684

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-08-30T13:01:01	2024-08-30T13:07:49
git_branch	master	smola/telemetry-logs-for-appsec
git_commit_date	1725019352	1725022192
git_commit_sha	`6025023`	`7865c85`
release_version	1.39.0-SNAPSHOT~6025023dd6	1.39.0-SNAPSHOT~7865c85a8d
start_time	2024-08-30T13:00:48	2024-08-30T13:07:35

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1725023612	1725023612
ci_job_id	622867733	622867733
ci_pipeline_id	43250336	43250336
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~7865c85a8d, baseline=1.39.0-SNAPSHOT~6025023dd6
    dateFormat X
    axisFormat %s
section baseline
no_agent (364.081 µs) : 345, 384
.   : milestone, 364,
iast (476.65 µs) : 454, 499
.   : milestone, 477,
iast_FULL (544.619 µs) : 523, 566
.   : milestone, 545,
iast_GLOBAL (497.104 µs) : 476, 518
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (477.518 µs) : 455, 500
.   : milestone, 478,
iast_INACTIVE (455.178 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (464.908 µs) : 443, 487
.   : milestone, 465,
tracing (431.437 µs) : 411, 452
.   : milestone, 431,
section candidate
no_agent (366.938 µs) : 347, 387
.   : milestone, 367,
iast (477.929 µs) : 456, 499
.   : milestone, 478,
iast_FULL (542.156 µs) : 521, 563
.   : milestone, 542,
iast_GLOBAL (505.911 µs) : 484, 528
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (482.953 µs) : 460, 505
.   : milestone, 483,
iast_INACTIVE (443.825 µs) : 423, 465
.   : milestone, 444,
iast_TELEMETRY_OFF (476.572 µs) : 453, 500
.   : milestone, 477,
tracing (446.456 µs) : 426, 467
.   : milestone, 446,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	364.081 µs [344.546 µs, 383.616 µs]	-
iast	476.65 µs [454.119 µs, 499.181 µs]	112.569 µs (30.9%)
iast_FULL	544.619 µs [523.16 µs, 566.077 µs]	180.538 µs (49.6%)
iast_GLOBAL	497.104 µs [476.036 µs, 518.173 µs]	133.024 µs (36.5%)
iast_HARDCODED_SECRET_DISABLED	477.518 µs [454.726 µs, 500.31 µs]	113.437 µs (31.2%)
iast_INACTIVE	455.178 µs [433.876 µs, 476.481 µs]	91.098 µs (25.0%)
iast_TELEMETRY_OFF	464.908 µs [442.708 µs, 487.108 µs]	100.827 µs (27.7%)
tracing	431.437 µs [411.129 µs, 451.744 µs]	67.356 µs (18.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	366.938 µs [347.245 µs, 386.632 µs]	-
iast	477.929 µs [456.495 µs, 499.363 µs]	110.991 µs (30.2%)
iast_FULL	542.156 µs [521.124 µs, 563.188 µs]	175.218 µs (47.8%)
iast_GLOBAL	505.911 µs [483.699 µs, 528.124 µs]	138.973 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED	482.953 µs [460.429 µs, 505.477 µs]	116.015 µs (31.6%)
iast_INACTIVE	443.825 µs [422.897 µs, 464.753 µs]	76.887 µs (21.0%)
iast_TELEMETRY_OFF	476.572 µs [453.203 µs, 499.94 µs]	109.634 µs (29.9%)
tracing	446.456 µs [425.561 µs, 467.35 µs]	79.518 µs (21.7%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~7865c85a8d, baseline=1.39.0-SNAPSHOT~6025023dd6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1375
.   : milestone, 1355,
appsec (1.707 ms) : 1684, 1731
.   : milestone, 1707,
appsec_no_iast (1.695 ms) : 1670, 1720
.   : milestone, 1695,
iast (1.464 ms) : 1442, 1486
.   : milestone, 1464,
profiling (1.483 ms) : 1460, 1506
.   : milestone, 1483,
tracing (1.457 ms) : 1433, 1481
.   : milestone, 1457,
section candidate
no_agent (1.321 ms) : 1301, 1340
.   : milestone, 1321,
appsec (1.693 ms) : 1669, 1717
.   : milestone, 1693,
appsec_no_iast (1.718 ms) : 1695, 1742
.   : milestone, 1718,
iast (1.462 ms) : 1439, 1484
.   : milestone, 1462,
profiling (1.514 ms) : 1489, 1539
.   : milestone, 1514,
tracing (1.466 ms) : 1442, 1490
.   : milestone, 1466,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.335 ms, 1.375 ms]	-
appsec	1.707 ms [1.684 ms, 1.731 ms]	352.222 µs (26.0%)
appsec_no_iast	1.695 ms [1.67 ms, 1.72 ms]	340.052 µs (25.1%)
iast	1.464 ms [1.442 ms, 1.486 ms]	109.051 µs (8.0%)
profiling	1.483 ms [1.46 ms, 1.506 ms]	127.651 µs (9.4%)
tracing	1.457 ms [1.433 ms, 1.481 ms]	101.907 µs (7.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.321 ms [1.301 ms, 1.34 ms]	-
appsec	1.693 ms [1.669 ms, 1.717 ms]	371.949 µs (28.2%)
appsec_no_iast	1.718 ms [1.695 ms, 1.742 ms]	397.431 µs (30.1%)
iast	1.462 ms [1.439 ms, 1.484 ms]	140.767 µs (10.7%)
profiling	1.514 ms [1.489 ms, 1.539 ms]	192.814 µs (14.6%)
tracing	1.466 ms [1.442 ms, 1.49 ms]	145.084 µs (11.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/telemetry-logs-for-appsec
git_commit_date	1725019352	1725022192
git_commit_sha	`6025023`	`7865c85`
release_version	1.39.0-SNAPSHOT~6025023dd6	1.39.0-SNAPSHOT~7865c85a8d

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1725024153	1725024153
ci_job_id	622867734	622867734
ci_pipeline_id	43250336	43250336
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~7865c85a8d, baseline=1.39.0-SNAPSHOT~6025023dd6
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.451 s) : 15451000, 15451000
.   : milestone, 15451000,
appsec (15.16 s) : 15160000, 15160000
.   : milestone, 15160000,
iast (18.785 s) : 18785000, 18785000
.   : milestone, 18785000,
iast_GLOBAL (18.032 s) : 18032000, 18032000
.   : milestone, 18032000,
profiling (15.64 s) : 15640000, 15640000
.   : milestone, 15640000,
tracing (14.887 s) : 14887000, 14887000
.   : milestone, 14887000,
section candidate
no_agent (15.436 s) : 15436000, 15436000
.   : milestone, 15436000,
appsec (15.02 s) : 15020000, 15020000
.   : milestone, 15020000,
iast (18.671 s) : 18671000, 18671000
.   : milestone, 18671000,
iast_GLOBAL (17.837 s) : 17837000, 17837000
.   : milestone, 17837000,
profiling (14.965 s) : 14965000, 14965000
.   : milestone, 14965000,
tracing (14.774 s) : 14774000, 14774000
.   : milestone, 14774000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.451 s [15.451 s, 15.451 s]	-
appsec	15.16 s [15.16 s, 15.16 s]	-291.0 ms (-1.9%)
iast	18.785 s [18.785 s, 18.785 s]	3.334 s (21.6%)
iast_GLOBAL	18.032 s [18.032 s, 18.032 s]	2.581 s (16.7%)
profiling	15.64 s [15.64 s, 15.64 s]	189.0 ms (1.2%)
tracing	14.887 s [14.887 s, 14.887 s]	-564.0 ms (-3.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.436 s [15.436 s, 15.436 s]	-
appsec	15.02 s [15.02 s, 15.02 s]	-416.0 ms (-2.7%)
iast	18.671 s [18.671 s, 18.671 s]	3.235 s (21.0%)
iast_GLOBAL	17.837 s [17.837 s, 17.837 s]	2.401 s (15.6%)
profiling	14.965 s [14.965 s, 14.965 s]	-471.0 ms (-3.1%)
tracing	14.774 s [14.774 s, 14.774 s]	-662.0 ms (-4.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~7865c85a8d, baseline=1.39.0-SNAPSHOT~6025023dd6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1474
.   : milestone, 1463,
appsec (2.219 ms) : 2185, 2254
.   : milestone, 2219,
iast (1.974 ms) : 1931, 2017
.   : milestone, 1974,
iast_GLOBAL (2.029 ms) : 1985, 2073
.   : milestone, 2029,
profiling (1.872 ms) : 1838, 1906
.   : milestone, 1872,
tracing (1.838 ms) : 1806, 1871
.   : milestone, 1838,
section candidate
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.249 ms) : 2214, 2285
.   : milestone, 2249,
iast (1.974 ms) : 1932, 2016
.   : milestone, 1974,
iast_GLOBAL (2.027 ms) : 1983, 2071
.   : milestone, 2027,
profiling (1.882 ms) : 1847, 1917
.   : milestone, 1882,
tracing (1.847 ms) : 1814, 1881
.   : milestone, 1847,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.463 ms [1.452 ms, 1.474 ms]	-
appsec	2.219 ms [2.185 ms, 2.254 ms]	756.168 µs (51.7%)
iast	1.974 ms [1.931 ms, 2.017 ms]	511.112 µs (34.9%)
iast_GLOBAL	2.029 ms [1.985 ms, 2.073 ms]	565.669 µs (38.7%)
profiling	1.872 ms [1.838 ms, 1.906 ms]	409.065 µs (28.0%)
tracing	1.838 ms [1.806 ms, 1.871 ms]	375.172 µs (25.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.462 ms [1.45 ms, 1.473 ms]	-
appsec	2.249 ms [2.214 ms, 2.285 ms]	787.826 µs (53.9%)
iast	1.974 ms [1.932 ms, 2.016 ms]	512.369 µs (35.1%)
iast_GLOBAL	2.027 ms [1.983 ms, 2.071 ms]	565.355 µs (38.7%)
profiling	1.882 ms [1.847 ms, 1.917 ms]	419.986 µs (28.7%)
tracing	1.847 ms [1.814 ms, 1.881 ms]	385.561 µs (26.4%)

smola added tag: diagnostics Diagnostics related changes comp: telemetry Telemetry labels Aug 30, 2024

Enable telemetry logs for services using AppSec

7865c85

smola force-pushed the smola/telemetry-logs-for-appsec branch from a4df16d to 7865c85 Compare August 30, 2024 12:50

smola marked this pull request as ready for review August 30, 2024 13:49

smola requested a review from a team as a code owner August 30, 2024 13:49

smola requested a review from nayeem-kamal August 30, 2024 13:49

PerfectSlayer approved these changes Aug 30, 2024

View reviewed changes

smola merged commit 7438ef7 into master Aug 30, 2024
90 checks passed

smola deleted the smola/telemetry-logs-for-appsec branch August 30, 2024 15:04

github-actions bot added this to the 1.39.0 milestone Aug 30, 2024

smola mentioned this pull request Sep 17, 2024

Enable telemetry logs by default #7631

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable telemetry logs for services using AppSec #7534

Enable telemetry logs for services using AppSec #7534

smola commented Aug 30, 2024

pr-commenter bot commented Aug 30, 2024

Enable telemetry logs for services using AppSec #7534

Enable telemetry logs for services using AppSec #7534

Conversation

smola commented Aug 30, 2024

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Aug 30, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary