Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable telemetry logs for a subset of Java versions #7475

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Enable telemetry logs for a subset of Java versions #7475

merged 1 commit into from
Aug 22, 2024

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Aug 20, 2024 •
edited
Loading

What Does This Do

This starts a progressive rollout using product independent sample.

Motivation

Enabling error tracking for more customers should help to raise any log volume issue, and help with SSI safeguards.

Additional Notes

Contributor Checklist

Jira ticket: APMLP-102

@PerfectSlayer PerfectSlayer requested a review from a team as a code owner August 20, 2024 06:08
@PerfectSlayer PerfectSlayer added tag: diagnostics Diagnostics related changes comp: crash tracking Crash tracking comp: telemetry Telemetry and removed comp: crash tracking Crash tracking labels Aug 20, 2024
@pr-commenter
Copy link

pr-commenter bot commented Aug 20, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/error-tracking
git_commit_date 1724144096 1724152519
git_commit_sha f14fb46 0b04153
release_version 1.39.0-SNAPSHOT~f14fb46821 1.39.0-SNAPSHOT~0b04153c98
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724154895 1724154895
ci_job_id 610227507 610227507
ci_pipeline_id 42246473 42246473
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~0b04153c98, baseline=1.39.0-SNAPSHOT~f14fb46821

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044795
Total [baseline] (8.482 s) : 0, 8482159
Agent [candidate] (1.045 s) : 0, 1045129
Total [candidate] (8.506 s) : 0, 8505597
section iast
Agent [baseline] (1.174 s) : 0, 1174083
Total [baseline] (8.975 s) : 0, 8975236
Agent [candidate] (1.172 s) : 0, 1172356
Total [candidate] (8.981 s) : 0, 8980941
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1184879
Total [baseline] (8.98 s) : 0, 8979999
Agent [candidate] (1.176 s) : 0, 1175520
Total [candidate] (8.989 s) : 0, 8989158
section iast_TELEMETRY_OFF
Agent [baseline] (1.171 s) : 0, 1170553
Total [baseline] (8.952 s) : 0, 8951867
Agent [candidate] (1.173 s) : 0, 1172537
Total [candidate] (8.942 s) : 0, 8941623
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.174 s 129.287 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 140.083 ms (13.4%)
Agent iast_TELEMETRY_OFF 1.171 s 125.758 ms (12.0%)
Total tracing 8.482 s -
Total iast 8.975 s 493.076 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.98 s 497.84 ms (5.9%)
Total iast_TELEMETRY_OFF 8.952 s 469.708 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.172 s 127.227 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 130.391 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.173 s 127.407 ms (12.2%)
Total tracing 8.506 s -
Total iast 8.981 s 475.344 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.989 s 483.561 ms (5.7%)
Total iast_TELEMETRY_OFF 8.942 s 436.026 ms (5.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~0b04153c98, baseline=1.39.0-SNAPSHOT~f14fb46821

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.015 ms) : 0, 667015
BytebuddyAgent [candidate] (666.774 ms) : 0, 666774
GlobalTracer [baseline] (305.597 ms) : 0, 305597
GlobalTracer [candidate] (305.597 ms) : 0, 305597
AppSec [baseline] (50.655 ms) : 0, 50655
AppSec [candidate] (51.176 ms) : 0, 51176
Remote Config [baseline] (677.884 µs) : 0, 678
Remote Config [candidate] (684.403 µs) : 0, 684
Telemetry [baseline] (7.414 ms) : 0, 7414
Telemetry [candidate] (7.468 ms) : 0, 7468
section iast
BytebuddyAgent [baseline] (781.589 ms) : 0, 781589
BytebuddyAgent [candidate] (779.658 ms) : 0, 779658
GlobalTracer [baseline] (295.465 ms) : 0, 295465
GlobalTracer [candidate] (295.463 ms) : 0, 295463
AppSec [baseline] (54.609 ms) : 0, 54609
AppSec [candidate] (53.069 ms) : 0, 53069
IAST [baseline] (21.424 ms) : 0, 21424
IAST [candidate] (22.319 ms) : 0, 22319
Remote Config [baseline] (563.468 µs) : 0, 563
Remote Config [candidate] (565.24 µs) : 0, 565
Telemetry [baseline] (7.05 ms) : 0, 7050
Telemetry [candidate] (7.861 ms) : 0, 7861
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (787.975 ms) : 0, 787975
BytebuddyAgent [candidate] (781.493 ms) : 0, 781493
GlobalTracer [baseline] (298.303 ms) : 0, 298303
GlobalTracer [candidate] (296.046 ms) : 0, 296046
AppSec [baseline] (49.018 ms) : 0, 49018
AppSec [candidate] (49.354 ms) : 0, 49354
IAST [baseline] (25.121 ms) : 0, 25121
IAST [candidate] (24.239 ms) : 0, 24239
Remote Config [baseline] (575.926 µs) : 0, 576
Remote Config [candidate] (580.603 µs) : 0, 581
Telemetry [baseline] (10.289 ms) : 0, 10289
Telemetry [candidate] (10.302 ms) : 0, 10302
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (778.62 ms) : 0, 778620
BytebuddyAgent [candidate] (779.033 ms) : 0, 779033
GlobalTracer [baseline] (295.779 ms) : 0, 295779
GlobalTracer [candidate] (296.791 ms) : 0, 296791
AppSec [baseline] (53.169 ms) : 0, 53169
AppSec [candidate] (52.741 ms) : 0, 52741
IAST [baseline] (21.954 ms) : 0, 21954
IAST [candidate] (22.864 ms) : 0, 22864
Remote Config [baseline] (601.956 µs) : 0, 602
Remote Config [candidate] (605.692 µs) : 0, 606
Telemetry [baseline] (6.96 ms) : 0, 6960
Telemetry [candidate] (6.979 ms) : 0, 6979
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~0b04153c98, baseline=1.39.0-SNAPSHOT~f14fb46821

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044647
Total [baseline] (10.293 s) : 0, 10293109
Agent [candidate] (1.042 s) : 0, 1042311
Total [candidate] (10.427 s) : 0, 10427374
section appsec
Agent [baseline] (1.174 s) : 0, 1174332
Total [baseline] (10.493 s) : 0, 10492706
Agent [candidate] (1.172 s) : 0, 1172110
Total [candidate] (10.471 s) : 0, 10470984
section iast
Agent [baseline] (1.184 s) : 0, 1184237
Total [baseline] (10.906 s) : 0, 10906491
Agent [candidate] (1.176 s) : 0, 1175917
Total [candidate] (10.976 s) : 0, 10975681
section profiling
Agent [baseline] (1.256 s) : 0, 1256056
Total [baseline] (10.658 s) : 0, 10658058
Agent [candidate] (1.251 s) : 0, 1250770
Total [candidate] (10.716 s) : 0, 10716369
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.174 s 129.685 ms (12.4%)
Agent iast 1.184 s 139.59 ms (13.4%)
Agent profiling 1.256 s 211.409 ms (20.2%)
Total tracing 10.293 s -
Total appsec 10.493 s 199.596 ms (1.9%)
Total iast 10.906 s 613.382 ms (6.0%)
Total profiling 10.658 s 364.949 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent appsec 1.172 s 129.799 ms (12.5%)
Agent iast 1.176 s 133.606 ms (12.8%)
Agent profiling 1.251 s 208.459 ms (20.0%)
Total tracing 10.427 s -
Total appsec 10.471 s 43.61 ms (0.4%)
Total iast 10.976 s 548.306 ms (5.3%)
Total profiling 10.716 s 288.995 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~0b04153c98, baseline=1.39.0-SNAPSHOT~f14fb46821

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.753 ms) : 0, 666753
BytebuddyAgent [candidate] (665.471 ms) : 0, 665471
GlobalTracer [baseline] (305.213 ms) : 0, 305213
GlobalTracer [candidate] (304.707 ms) : 0, 304707
AppSec [baseline] (51.043 ms) : 0, 51043
AppSec [candidate] (50.699 ms) : 0, 50699
Remote Config [baseline] (686.284 µs) : 0, 686
Remote Config [candidate] (682.674 µs) : 0, 683
Telemetry [baseline] (7.546 ms) : 0, 7546
Telemetry [candidate] (7.4 ms) : 0, 7400
section appsec
BytebuddyAgent [baseline] (681.734 ms) : 0, 681734
BytebuddyAgent [candidate] (680.16 ms) : 0, 680160
GlobalTracer [baseline] (300.828 ms) : 0, 300828
GlobalTracer [candidate] (300.697 ms) : 0, 300697
AppSec [baseline] (157.98 ms) : 0, 157980
AppSec [candidate] (157.43 ms) : 0, 157430
IAST [baseline] (23.04 ms) : 0, 23040
IAST [candidate] (20.737 ms) : 0, 20737
Remote Config [baseline] (604.168 µs) : 0, 604
Remote Config [candidate] (605.068 µs) : 0, 605
Telemetry [baseline] (8.121 ms) : 0, 8121
Telemetry [candidate] (9.326 ms) : 0, 9326
section iast
BytebuddyAgent [baseline] (787.458 ms) : 0, 787458
BytebuddyAgent [candidate] (781.804 ms) : 0, 781804
GlobalTracer [baseline] (298.071 ms) : 0, 298071
GlobalTracer [candidate] (297.265 ms) : 0, 297265
AppSec [baseline] (53.662 ms) : 0, 53662
AppSec [candidate] (52.281 ms) : 0, 52281
IAST [baseline] (22.795 ms) : 0, 22795
IAST [candidate] (22.55 ms) : 0, 22550
Remote Config [baseline] (586.939 µs) : 0, 587
Remote Config [candidate] (574.492 µs) : 0, 574
Telemetry [baseline] (8.124 ms) : 0, 8124
Telemetry [candidate] (7.958 ms) : 0, 7958
section profiling
BytebuddyAgent [baseline] (668.821 ms) : 0, 668821
BytebuddyAgent [candidate] (667.921 ms) : 0, 667921
GlobalTracer [baseline] (392.372 ms) : 0, 392372
GlobalTracer [candidate] (390.502 ms) : 0, 390502
AppSec [baseline] (52.753 ms) : 0, 52753
AppSec [candidate] (52.049 ms) : 0, 52049
Remote Config [baseline] (693.186 µs) : 0, 693
Remote Config [candidate] (693.632 µs) : 0, 694
Telemetry [baseline] (7.491 ms) : 0, 7491
Telemetry [candidate] (7.415 ms) : 0, 7415
ProfilingAgent [baseline] (96.54 ms) : 0, 96540
ProfilingAgent [candidate] (94.82 ms) : 0, 94820
Profiling [baseline] (96.565 ms) : 0, 96565
Profiling [candidate] (94.844 ms) : 0, 94844
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-20T11:25:32 2024-08-20T11:32:21
git_branch master bbujon/error-tracking
git_commit_date 1724144096 1724152519
git_commit_sha f14fb46 0b04153
release_version 1.39.0-SNAPSHOT~f14fb46821 1.39.0-SNAPSHOT~0b04153c98
start_time 2024-08-20T11:25:19 2024-08-20T11:32:08
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1724153886 1724153886
ci_job_id 610227508 610227508
ci_pipeline_id 42246473 42246473
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~0b04153c98, baseline=1.39.0-SNAPSHOT~f14fb46821
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.79 µs) : 343, 384
.   : milestone, 364,
iast (483.581 µs) : 462, 505
.   : milestone, 484,
iast_FULL (551.782 µs) : 529, 574
.   : milestone, 552,
iast_GLOBAL (506.492 µs) : 484, 529
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (487.961 µs) : 467, 509
.   : milestone, 488,
iast_INACTIVE (462.237 µs) : 439, 485
.   : milestone, 462,
iast_TELEMETRY_OFF (473.884 µs) : 452, 496
.   : milestone, 474,
tracing (440.95 µs) : 420, 461
.   : milestone, 441,
section candidate
no_agent (368.958 µs) : 349, 389
.   : milestone, 369,
iast (477.087 µs) : 456, 498
.   : milestone, 477,
iast_FULL (551.406 µs) : 529, 574
.   : milestone, 551,
iast_GLOBAL (507.234 µs) : 485, 530
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (488.634 µs) : 467, 510
.   : milestone, 489,
iast_INACTIVE (454.739 µs) : 432, 477
.   : milestone, 455,
iast_TELEMETRY_OFF (474.993 µs) : 453, 497
.   : milestone, 475,
tracing (444.787 µs) : 424, 465
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.79 µs [343.256 µs, 384.323 µs] -
iast 483.581 µs [462.183 µs, 504.978 µs] 119.791 µs (32.9%)
iast_FULL 551.782 µs [529.384 µs, 574.18 µs] 187.992 µs (51.7%)
iast_GLOBAL 506.492 µs [483.662 µs, 529.323 µs] 142.703 µs (39.2%)
iast_HARDCODED_SECRET_DISABLED 487.961 µs [466.617 µs, 509.306 µs] 124.172 µs (34.1%)
iast_INACTIVE 462.237 µs [439.458 µs, 485.016 µs] 98.447 µs (27.1%)
iast_TELEMETRY_OFF 473.884 µs [452.152 µs, 495.615 µs] 110.094 µs (30.3%)
tracing 440.95 µs [420.494 µs, 461.407 µs] 77.161 µs (21.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.958 µs [348.675 µs, 389.242 µs] -
iast 477.087 µs [455.82 µs, 498.354 µs] 108.129 µs (29.3%)
iast_FULL 551.406 µs [528.626 µs, 574.187 µs] 182.448 µs (49.4%)
iast_GLOBAL 507.234 µs [484.852 µs, 529.616 µs] 138.276 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 488.634 µs [467.331 µs, 509.936 µs] 119.676 µs (32.4%)
iast_INACTIVE 454.739 µs [432.467 µs, 477.011 µs] 85.781 µs (23.2%)
iast_TELEMETRY_OFF 474.993 µs [453.318 µs, 496.668 µs] 106.035 µs (28.7%)
tracing 444.787 µs [424.352 µs, 465.222 µs] 75.829 µs (20.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~0b04153c98, baseline=1.39.0-SNAPSHOT~f14fb46821
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1329, 1371
.   : milestone, 1350,
appsec (1.748 ms) : 1724, 1772
.   : milestone, 1748,
appsec_no_iast (1.727 ms) : 1702, 1751
.   : milestone, 1727,
iast (1.473 ms) : 1451, 1495
.   : milestone, 1473,
profiling (1.482 ms) : 1457, 1507
.   : milestone, 1482,
tracing (1.449 ms) : 1424, 1473
.   : milestone, 1449,
section candidate
no_agent (1.35 ms) : 1331, 1370
.   : milestone, 1350,
appsec (1.718 ms) : 1694, 1743
.   : milestone, 1718,
appsec_no_iast (1.708 ms) : 1683, 1733
.   : milestone, 1708,
iast (1.475 ms) : 1453, 1498
.   : milestone, 1475,
profiling (1.498 ms) : 1473, 1522
.   : milestone, 1498,
tracing (1.453 ms) : 1428, 1477
.   : milestone, 1453,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.329 ms, 1.371 ms] -
appsec 1.748 ms [1.724 ms, 1.772 ms] 397.65 µs (29.5%)
appsec_no_iast 1.727 ms [1.702 ms, 1.751 ms] 376.569 µs (27.9%)
iast 1.473 ms [1.451 ms, 1.495 ms] 122.72 µs (9.1%)
profiling 1.482 ms [1.457 ms, 1.507 ms] 132.031 µs (9.8%)
tracing 1.449 ms [1.424 ms, 1.473 ms] 98.691 µs (7.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.37 ms] -
appsec 1.718 ms [1.694 ms, 1.743 ms] 368.059 µs (27.3%)
appsec_no_iast 1.708 ms [1.683 ms, 1.733 ms] 357.911 µs (26.5%)
iast 1.475 ms [1.453 ms, 1.498 ms] 125.231 µs (9.3%)
profiling 1.498 ms [1.473 ms, 1.522 ms] 147.638 µs (10.9%)
tracing 1.453 ms [1.428 ms, 1.477 ms] 102.533 µs (7.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/error-tracking
git_commit_date 1724144096 1724152519
git_commit_sha f14fb46 0b04153
release_version 1.39.0-SNAPSHOT~f14fb46821 1.39.0-SNAPSHOT~0b04153c98
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1724154406 1724154406
ci_job_id 610227509 610227509
ci_pipeline_id 42246473 42246473
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~0b04153c98, baseline=1.39.0-SNAPSHOT~f14fb46821
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1471
.   : milestone, 1460,
appsec (2.23 ms) : 2195, 2265
.   : milestone, 2230,
iast (1.988 ms) : 1945, 2030
.   : milestone, 1988,
iast_GLOBAL (2.021 ms) : 1978, 2065
.   : milestone, 2021,
profiling (1.864 ms) : 1829, 1898
.   : milestone, 1864,
tracing (1.837 ms) : 1805, 1870
.   : milestone, 1837,
section candidate
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.241 ms) : 2205, 2277
.   : milestone, 2241,
iast (1.976 ms) : 1934, 2018
.   : milestone, 1976,
iast_GLOBAL (2.02 ms) : 1977, 2063
.   : milestone, 2020,
profiling (1.87 ms) : 1835, 1905
.   : milestone, 1870,
tracing (1.843 ms) : 1810, 1876
.   : milestone, 1843,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.471 ms] -
appsec 2.23 ms [2.195 ms, 2.265 ms] 769.884 µs (52.7%)
iast 1.988 ms [1.945 ms, 2.03 ms] 527.45 µs (36.1%)
iast_GLOBAL 2.021 ms [1.978 ms, 2.065 ms] 561.28 µs (38.4%)
profiling 1.864 ms [1.829 ms, 1.898 ms] 403.377 µs (27.6%)
tracing 1.837 ms [1.805 ms, 1.87 ms] 376.936 µs (25.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.447 ms, 1.47 ms] -
appsec 2.241 ms [2.205 ms, 2.277 ms] 782.706 µs (53.7%)
iast 1.976 ms [1.934 ms, 2.018 ms] 517.42 µs (35.5%)
iast_GLOBAL 2.02 ms [1.977 ms, 2.063 ms] 561.769 µs (38.5%)
profiling 1.87 ms [1.835 ms, 1.905 ms] 411.195 µs (28.2%)
tracing 1.843 ms [1.81 ms, 1.876 ms] 384.297 µs (26.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~0b04153c98, baseline=1.39.0-SNAPSHOT~f14fb46821
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.62 s) : 15620000, 15620000
.   : milestone, 15620000,
appsec (15.215 s) : 15215000, 15215000
.   : milestone, 15215000,
iast (18.494 s) : 18494000, 18494000
.   : milestone, 18494000,
iast_GLOBAL (17.821 s) : 17821000, 17821000
.   : milestone, 17821000,
profiling (15.156 s) : 15156000, 15156000
.   : milestone, 15156000,
tracing (14.752 s) : 14752000, 14752000
.   : milestone, 14752000,
section candidate
no_agent (15.26 s) : 15260000, 15260000
.   : milestone, 15260000,
appsec (15.192 s) : 15192000, 15192000
.   : milestone, 15192000,
iast (18.588 s) : 18588000, 18588000
.   : milestone, 18588000,
iast_GLOBAL (18.049 s) : 18049000, 18049000
.   : milestone, 18049000,
profiling (15.127 s) : 15127000, 15127000
.   : milestone, 15127000,
tracing (14.866 s) : 14866000, 14866000
.   : milestone, 14866000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.62 s [15.62 s, 15.62 s] -
appsec 15.215 s [15.215 s, 15.215 s] -405.0 ms (-2.6%)
iast 18.494 s [18.494 s, 18.494 s] 2.874 s (18.4%)
iast_GLOBAL 17.821 s [17.821 s, 17.821 s] 2.201 s (14.1%)
profiling 15.156 s [15.156 s, 15.156 s] -464.0 ms (-3.0%)
tracing 14.752 s [14.752 s, 14.752 s] -868.0 ms (-5.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.26 s [15.26 s, 15.26 s] -
appsec 15.192 s [15.192 s, 15.192 s] -68.0 ms (-0.4%)
iast 18.588 s [18.588 s, 18.588 s] 3.328 s (21.8%)
iast_GLOBAL 18.049 s [18.049 s, 18.049 s] 2.789 s (18.3%)
profiling 15.127 s [15.127 s, 15.127 s] -133.0 ms (-0.9%)
tracing 14.866 s [14.866 s, 14.866 s] -394.0 ms (-2.6%)

@PerfectSlayer
feat(errortracking): Enable error tracking for Java < 11 by default
0b04153 
This starts a progressive rollout using product independent sample.
@PerfectSlayer PerfectSlayer force-pushed the bbujon/error-tracking branch from 00310d5 to 0b04153 Compare August 20, 2024 11:16
@PerfectSlayer PerfectSlayer requested a review from smola August 20, 2024 11:16
@PerfectSlayer PerfectSlayer changed the title Enable error tracking for Java < 11 hosts Enable telemetry logs for a subset of Java versions Aug 21, 2024
@PerfectSlayer PerfectSlayer merged commit 5f75847 into master Aug 22, 2024
80 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/error-tracking branch August 22, 2024 14:03
@github-actions github-actions bot added this to the 1.39.0 milestone Aug 22, 2024
@smola smola mentioned this pull request Sep 17, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: telemetry Telemetry tag: diagnostics Diagnostics related changes
Projects
None yet
Milestone
1.39.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PerfectSlayer @smola