-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cloudfoundry automation with HTTP 2 support #7454
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~16befc65e6, baseline=1.39.0-SNAPSHOT~ea0cdda308
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043066
Total [baseline] (8.48 s) : 0, 8480200
Agent [candidate] (1.048 s) : 0, 1047528
Total [candidate] (8.541 s) : 0, 8541405
section iast
Agent [baseline] (1.174 s) : 0, 1174281
Total [baseline] (8.982 s) : 0, 8982368
Agent [candidate] (1.177 s) : 0, 1177303
Total [candidate] (8.983 s) : 0, 8982763
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1173650
Total [baseline] (8.998 s) : 0, 8997615
Agent [candidate] (1.177 s) : 0, 1176892
Total [candidate] (8.98 s) : 0, 8979732
section iast_TELEMETRY_OFF
Agent [baseline] (1.171 s) : 0, 1171312
Total [baseline] (9.007 s) : 0, 9007442
Agent [candidate] (1.172 s) : 0, 1172146
Total [candidate] (9.008 s) : 0, 9007551
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~16befc65e6, baseline=1.39.0-SNAPSHOT~ea0cdda308
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.603 ms) : 0, 665603
BytebuddyAgent [candidate] (667.49 ms) : 0, 667490
GlobalTracer [baseline] (304.992 ms) : 0, 304992
GlobalTracer [candidate] (307.142 ms) : 0, 307142
AppSec [baseline] (50.901 ms) : 0, 50901
AppSec [candidate] (51.163 ms) : 0, 51163
Remote Config [baseline] (686.542 µs) : 0, 687
Remote Config [candidate] (685.976 µs) : 0, 686
Telemetry [baseline] (7.454 ms) : 0, 7454
Telemetry [candidate] (7.562 ms) : 0, 7562
section iast
BytebuddyAgent [baseline] (780.992 ms) : 0, 780992
BytebuddyAgent [candidate] (782.998 ms) : 0, 782998
GlobalTracer [baseline] (295.61 ms) : 0, 295610
GlobalTracer [candidate] (296.714 ms) : 0, 296714
AppSec [baseline] (52.504 ms) : 0, 52504
AppSec [candidate] (52.336 ms) : 0, 52336
Remote Config [baseline] (572.881 µs) : 0, 573
Remote Config [candidate] (581.583 µs) : 0, 582
Telemetry [baseline] (7.91 ms) : 0, 7910
Telemetry [candidate] (7.939 ms) : 0, 7939
IAST [baseline] (23.253 ms) : 0, 23253
IAST [candidate] (23.201 ms) : 0, 23201
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.441 ms) : 0, 780441
BytebuddyAgent [candidate] (782.382 ms) : 0, 782382
GlobalTracer [baseline] (296.323 ms) : 0, 296323
GlobalTracer [candidate] (296.957 ms) : 0, 296957
AppSec [baseline] (49.508 ms) : 0, 49508
AppSec [candidate] (50.181 ms) : 0, 50181
Remote Config [baseline] (588.786 µs) : 0, 589
Remote Config [candidate] (579.838 µs) : 0, 580
Telemetry [baseline] (9.642 ms) : 0, 9642
Telemetry [candidate] (8.001 ms) : 0, 8001
IAST [baseline] (23.683 ms) : 0, 23683
IAST [candidate] (25.284 ms) : 0, 25284
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.254 ms) : 0, 779254
BytebuddyAgent [candidate] (779.002 ms) : 0, 779002
GlobalTracer [baseline] (296.448 ms) : 0, 296448
GlobalTracer [candidate] (296.997 ms) : 0, 296997
AppSec [baseline] (52.205 ms) : 0, 52205
AppSec [candidate] (52.146 ms) : 0, 52146
Remote Config [baseline] (611.589 µs) : 0, 612
Remote Config [candidate] (610.055 µs) : 0, 610
Telemetry [baseline] (7.101 ms) : 0, 7101
Telemetry [candidate] (7.091 ms) : 0, 7091
IAST [baseline] (22.218 ms) : 0, 22218
IAST [candidate] (22.809 ms) : 0, 22809
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~16befc65e6, baseline=1.39.0-SNAPSHOT~ea0cdda308
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046946
Total [baseline] (10.37 s) : 0, 10369886
Agent [candidate] (1.048 s) : 0, 1048221
Total [candidate] (10.368 s) : 0, 10367990
section appsec
Agent [baseline] (1.186 s) : 0, 1186404
Total [baseline] (10.517 s) : 0, 10516777
Agent [candidate] (1.174 s) : 0, 1173967
Total [candidate] (10.546 s) : 0, 10546292
section iast
Agent [baseline] (1.179 s) : 0, 1179473
Total [baseline] (10.83 s) : 0, 10829755
Agent [candidate] (1.175 s) : 0, 1174787
Total [candidate] (10.788 s) : 0, 10787974
section profiling
Agent [baseline] (1.254 s) : 0, 1254105
Total [baseline] (10.652 s) : 0, 10652036
Agent [candidate] (1.246 s) : 0, 1246184
Total [candidate] (10.627 s) : 0, 10626640
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~16befc65e6, baseline=1.39.0-SNAPSHOT~ea0cdda308
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.825 ms) : 0, 667825
BytebuddyAgent [candidate] (668.656 ms) : 0, 668656
GlobalTracer [baseline] (306.455 ms) : 0, 306455
GlobalTracer [candidate] (307.063 ms) : 0, 307063
AppSec [baseline] (50.974 ms) : 0, 50974
AppSec [candidate] (50.872 ms) : 0, 50872
Remote Config [baseline] (697.91 µs) : 0, 698
Remote Config [candidate] (677.447 µs) : 0, 677
Telemetry [baseline] (7.559 ms) : 0, 7559
Telemetry [candidate] (7.521 ms) : 0, 7521
section appsec
BytebuddyAgent [baseline] (688.54 ms) : 0, 688540
BytebuddyAgent [candidate] (681.204 ms) : 0, 681204
GlobalTracer [baseline] (303.963 ms) : 0, 303963
GlobalTracer [candidate] (300.602 ms) : 0, 300602
AppSec [baseline] (158.92 ms) : 0, 158920
AppSec [candidate] (157.756 ms) : 0, 157756
Remote Config [baseline] (614.385 µs) : 0, 614
Remote Config [candidate] (601.44 µs) : 0, 601
Telemetry [baseline] (9.839 ms) : 0, 9839
Telemetry [candidate] (9.11 ms) : 0, 9110
IAST [baseline] (21.771 ms) : 0, 21771
IAST [candidate] (22.326 ms) : 0, 22326
section iast
BytebuddyAgent [baseline] (784.839 ms) : 0, 784839
BytebuddyAgent [candidate] (780.959 ms) : 0, 780959
GlobalTracer [baseline] (297.5 ms) : 0, 297500
GlobalTracer [candidate] (296.337 ms) : 0, 296337
AppSec [baseline] (52.138 ms) : 0, 52138
AppSec [candidate] (52.6 ms) : 0, 52600
Remote Config [baseline] (558.792 µs) : 0, 559
Remote Config [candidate] (577.412 µs) : 0, 577
Telemetry [baseline] (7.818 ms) : 0, 7818
Telemetry [candidate] (7.841 ms) : 0, 7841
IAST [baseline] (23.091 ms) : 0, 23091
IAST [candidate] (23.014 ms) : 0, 23014
section profiling
BytebuddyAgent [baseline] (667.585 ms) : 0, 667585
BytebuddyAgent [candidate] (663.651 ms) : 0, 663651
GlobalTracer [baseline] (392.232 ms) : 0, 392232
GlobalTracer [candidate] (391.363 ms) : 0, 391363
AppSec [baseline] (52.79 ms) : 0, 52790
AppSec [candidate] (52.218 ms) : 0, 52218
Remote Config [baseline] (692.398 µs) : 0, 692
Remote Config [candidate] (682.261 µs) : 0, 682
Telemetry [baseline] (7.489 ms) : 0, 7489
Telemetry [candidate] (7.346 ms) : 0, 7346
ProfilingAgent [baseline] (95.934 ms) : 0, 95934
ProfilingAgent [candidate] (93.808 ms) : 0, 93808
Profiling [baseline] (95.959 ms) : 0, 95959
Profiling [candidate] (93.833 ms) : 0, 93833
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~16befc65e6, baseline=1.39.0-SNAPSHOT~ea0cdda308
dateFormat X
axisFormat %s
section baseline
no_agent (365.783 µs) : 347, 385
. : milestone, 366,
iast (474.505 µs) : 453, 496
. : milestone, 475,
iast_FULL (550.639 µs) : 528, 573
. : milestone, 551,
iast_GLOBAL (514.673 µs) : 491, 538
. : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (480.046 µs) : 459, 501
. : milestone, 480,
iast_INACTIVE (455.166 µs) : 432, 478
. : milestone, 455,
iast_TELEMETRY_OFF (474.369 µs) : 452, 496
. : milestone, 474,
tracing (439.01 µs) : 419, 459
. : milestone, 439,
section candidate
no_agent (361.649 µs) : 342, 381
. : milestone, 362,
iast (482.383 µs) : 459, 506
. : milestone, 482,
iast_FULL (549.752 µs) : 527, 572
. : milestone, 550,
iast_GLOBAL (504.587 µs) : 481, 528
. : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (472.535 µs) : 452, 493
. : milestone, 473,
iast_INACTIVE (450.72 µs) : 428, 473
. : milestone, 451,
iast_TELEMETRY_OFF (468.371 µs) : 447, 490
. : milestone, 468,
tracing (436.932 µs) : 417, 457
. : milestone, 437,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~16befc65e6, baseline=1.39.0-SNAPSHOT~ea0cdda308
dateFormat X
axisFormat %s
section baseline
no_agent (1.323 ms) : 1303, 1343
. : milestone, 1323,
appsec (1.718 ms) : 1694, 1741
. : milestone, 1718,
appsec_no_iast (1.729 ms) : 1705, 1753
. : milestone, 1729,
iast (1.478 ms) : 1456, 1500
. : milestone, 1478,
profiling (1.471 ms) : 1447, 1496
. : milestone, 1471,
tracing (1.472 ms) : 1447, 1496
. : milestone, 1472,
section candidate
no_agent (1.338 ms) : 1318, 1357
. : milestone, 1338,
appsec (1.724 ms) : 1700, 1748
. : milestone, 1724,
appsec_no_iast (1.731 ms) : 1708, 1754
. : milestone, 1731,
iast (1.485 ms) : 1463, 1508
. : milestone, 1485,
profiling (1.491 ms) : 1466, 1516
. : milestone, 1491,
tracing (1.449 ms) : 1425, 1473
. : milestone, 1449,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~16befc65e6, baseline=1.39.0-SNAPSHOT~ea0cdda308
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.239 ms) : 2204, 2275
. : milestone, 2239,
iast (1.974 ms) : 1932, 2016
. : milestone, 1974,
iast_GLOBAL (2.017 ms) : 1973, 2061
. : milestone, 2017,
profiling (1.867 ms) : 1833, 1901
. : milestone, 1867,
tracing (1.831 ms) : 1798, 1864
. : milestone, 1831,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (2.213 ms) : 2179, 2247
. : milestone, 2213,
iast (1.963 ms) : 1922, 2004
. : milestone, 1963,
iast_GLOBAL (2.021 ms) : 1978, 2064
. : milestone, 2021,
profiling (1.858 ms) : 1822, 1893
. : milestone, 1858,
tracing (1.839 ms) : 1807, 1872
. : milestone, 1839,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~16befc65e6, baseline=1.39.0-SNAPSHOT~ea0cdda308
dateFormat X
axisFormat %s
section baseline
no_agent (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
appsec (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
iast (19.035 s) : 19035000, 19035000
. : milestone, 19035000,
iast_GLOBAL (18.163 s) : 18163000, 18163000
. : milestone, 18163000,
profiling (15.918 s) : 15918000, 15918000
. : milestone, 15918000,
tracing (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
section candidate
no_agent (15.146 s) : 15146000, 15146000
. : milestone, 15146000,
appsec (14.895 s) : 14895000, 14895000
. : milestone, 14895000,
iast (18.732 s) : 18732000, 18732000
. : milestone, 18732000,
iast_GLOBAL (18.001 s) : 18001000, 18001000
. : milestone, 18001000,
profiling (15.208 s) : 15208000, 15208000
. : milestone, 15208000,
tracing (15.072 s) : 15072000, 15072000
. : milestone, 15072000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! 👍
What Does This Do
It seems Maven Central added HTTP/2 support, leading to different curl output in our automation. For HTTP 1.1 it's
HTTP/1.1 200 OK
and for HTTP 2 it'sHTTP/2 200
. Currently workflow gets stuck because of this: https://github.com/DataDog/dd-trace-java/actions/runs/10418982507/job/28856149889Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]