JVM version output can omit minor or patch suffixes #7068

MattAlp · 2024-05-23T21:33:35Z

What Does This Do

Patches the setup script to account for release numbers with minor / patch omitted.

Motivation

The ./setup.sh script presumes that the version number output of java -version will follow semver conventions, so major versions will be followed by a .. In the case of some JDKs, i.e. Temurin 17, the output only includes the major number:

dd-trace-java % $JAVA_17_HOME/bin/java -version                                
openjdk version "17" 2021-09-14
OpenJDK Runtime Environment Temurin-17+35 (build 17+35)
OpenJDK 64-Bit Server VM Temurin-17+35 (build 17+35, mixed mode)

Additional Notes

Jira ticket: will backfill if needed

PerfectSlayer

Thanks for the fix! ❤️

smola · 2024-05-24T14:00:37Z

setup.sh

@@ -10,7 +10,7 @@ function check-jvm() {
    if [ -z ${!JAVA_HOME_NAME} ]; then
        echo "❌ $JAVA_HOME_NAME is not set. Please set $JAVA_HOME_NAME to refer to a JDK $EXPECTED_JAVA_VERSION installation." >&2
        exit 1
-    elif ! ${!JAVA_HOME_NAME}/bin/java -version 2>&1 | grep -q "version \"$EXPECTED_JAVA_VERSION\." ; then
+    elif ! ${!JAVA_HOME_NAME}/bin/java -version 2>&1 | grep -q "version \"$EXPECTED_JAVA_VERSION" ; then


I guess Java 80 is far enough in the future for this to be a problem 😉

pr-commenter · 2024-08-08T16:02:58Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mattalp/update-setup-script
git_commit_date	1723106406	1723130442
git_commit_sha	`39a68b3`	`61e8eef`
release_version	1.39.0-SNAPSHOT~39a68b33b5	1.39.0-SNAPSHOT~61e8eefc93

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1723132930	1723132930
ci_job_id	599018641	599018641
ci_pipeline_id	41239355	41239355
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~61e8eefc93, baseline=1.39.0-SNAPSHOT~39a68b33b5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053682
Total [baseline] (10.312 s) : 0, 10312302
Agent [candidate] (1.055 s) : 0, 1054576
Total [candidate] (10.352 s) : 0, 10351759
section appsec
Agent [baseline] (1.172 s) : 0, 1171514
Total [baseline] (10.565 s) : 0, 10565264
Agent [candidate] (1.174 s) : 0, 1173588
Total [candidate] (10.524 s) : 0, 10523623
section iast
Agent [baseline] (1.185 s) : 0, 1185445
Total [baseline] (10.784 s) : 0, 10783801
Agent [candidate] (1.192 s) : 0, 1191693
Total [candidate] (10.874 s) : 0, 10873919
section profiling
Agent [baseline] (1.245 s) : 0, 1244899
Total [baseline] (10.626 s) : 0, 10625673
Agent [candidate] (1.247 s) : 0, 1247002
Total [candidate] (10.603 s) : 0, 10602551

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.054 s	-
Agent	appsec	1.172 s	117.832 ms (11.2%)
Agent	iast	1.185 s	131.763 ms (12.5%)
Agent	profiling	1.245 s	191.217 ms (18.1%)
Total	tracing	10.312 s	-
Total	appsec	10.565 s	252.962 ms (2.5%)
Total	iast	10.784 s	471.499 ms (4.6%)
Total	profiling	10.626 s	313.371 ms (3.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	appsec	1.174 s	119.012 ms (11.3%)
Agent	iast	1.192 s	137.117 ms (13.0%)
Agent	profiling	1.247 s	192.426 ms (18.2%)
Total	tracing	10.352 s	-
Total	appsec	10.524 s	171.863 ms (1.7%)
Total	iast	10.874 s	522.159 ms (5.0%)
Total	profiling	10.603 s	250.792 ms (2.4%)

gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~61e8eefc93, baseline=1.39.0-SNAPSHOT~39a68b33b5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.521 ms) : 0, 673521
BytebuddyAgent [candidate] (673.17 ms) : 0, 673170
GlobalTracer [baseline] (308.022 ms) : 0, 308022
GlobalTracer [candidate] (309.123 ms) : 0, 309123
AppSec [baseline] (50.496 ms) : 0, 50496
AppSec [candidate] (50.645 ms) : 0, 50645
Remote Config [baseline] (701.3 µs) : 0, 701
Remote Config [candidate] (701.912 µs) : 0, 702
Telemetry [baseline] (7.399 ms) : 0, 7399
Telemetry [candidate] (7.393 ms) : 0, 7393
section appsec
BytebuddyAgent [baseline] (680.897 ms) : 0, 680897
BytebuddyAgent [candidate] (683.194 ms) : 0, 683194
GlobalTracer [baseline] (300.945 ms) : 0, 300945
GlobalTracer [candidate] (300.844 ms) : 0, 300844
AppSec [baseline] (155.343 ms) : 0, 155343
AppSec [candidate] (155.7 ms) : 0, 155700
Remote Config [baseline] (609.486 µs) : 0, 609
Remote Config [candidate] (610.463 µs) : 0, 610
Telemetry [baseline] (9.147 ms) : 0, 9147
Telemetry [candidate] (8.227 ms) : 0, 8227
IAST [baseline] (22.048 ms) : 0, 22048
IAST [candidate] (22.834 ms) : 0, 22834
section iast
BytebuddyAgent [baseline] (789.456 ms) : 0, 789456
BytebuddyAgent [candidate] (794.445 ms) : 0, 794445
GlobalTracer [baseline] (298.394 ms) : 0, 298394
GlobalTracer [candidate] (300.308 ms) : 0, 300308
AppSec [baseline] (50.467 ms) : 0, 50467
AppSec [candidate] (51.3 ms) : 0, 51300
Remote Config [baseline] (584.813 µs) : 0, 585
Remote Config [candidate] (620.252 µs) : 0, 620
Telemetry [baseline] (9.536 ms) : 0, 9536
Telemetry [candidate] (7.015 ms) : 0, 7015
IAST [baseline] (23.415 ms) : 0, 23415
IAST [candidate] (24.324 ms) : 0, 24324
section profiling
BytebuddyAgent [baseline] (662.852 ms) : 0, 662852
BytebuddyAgent [candidate] (664.373 ms) : 0, 664373
GlobalTracer [baseline] (390.482 ms) : 0, 390482
GlobalTracer [candidate] (391.12 ms) : 0, 391120
AppSec [baseline] (51.221 ms) : 0, 51221
AppSec [candidate] (51.23 ms) : 0, 51230
Remote Config [baseline] (680.105 µs) : 0, 680
Remote Config [candidate] (699.099 µs) : 0, 699
Telemetry [baseline] (7.21 ms) : 0, 7210
Telemetry [candidate] (7.223 ms) : 0, 7223
ProfilingAgent [baseline] (95.262 ms) : 0, 95262
ProfilingAgent [candidate] (95.1 ms) : 0, 95100
Profiling [baseline] (95.286 ms) : 0, 95286
Profiling [candidate] (95.124 ms) : 0, 95124

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~61e8eefc93, baseline=1.39.0-SNAPSHOT~39a68b33b5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054285
Total [baseline] (8.5 s) : 0, 8500485
Agent [candidate] (1.051 s) : 0, 1050515
Total [candidate] (8.529 s) : 0, 8529166
section iast
Agent [baseline] (1.178 s) : 0, 1177708
Total [baseline] (9.039 s) : 0, 9039489
Agent [candidate] (1.192 s) : 0, 1191568
Total [candidate] (9.031 s) : 0, 9030742
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1185846
Total [baseline] (8.974 s) : 0, 8974161
Agent [candidate] (1.175 s) : 0, 1175313
Total [candidate] (8.969 s) : 0, 8968981
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1173205
Total [baseline] (8.996 s) : 0, 8996379
Agent [candidate] (1.173 s) : 0, 1172716
Total [candidate] (9.016 s) : 0, 9015643

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.054 s	-
Agent	iast	1.178 s	123.424 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.186 s	131.562 ms (12.5%)
Agent	iast_TELEMETRY_OFF	1.173 s	118.92 ms (11.3%)
Total	tracing	8.5 s	-
Total	iast	9.039 s	539.004 ms (6.3%)
Total	iast_HARDCODED_SECRET_DISABLED	8.974 s	473.676 ms (5.6%)
Total	iast_TELEMETRY_OFF	8.996 s	495.895 ms (5.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.051 s	-
Agent	iast	1.192 s	141.053 ms (13.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.175 s	124.799 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.173 s	122.201 ms (11.6%)
Total	tracing	8.529 s	-
Total	iast	9.031 s	501.576 ms (5.9%)
Total	iast_HARDCODED_SECRET_DISABLED	8.969 s	439.815 ms (5.2%)
Total	iast_TELEMETRY_OFF	9.016 s	486.477 ms (5.7%)

gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~61e8eefc93, baseline=1.39.0-SNAPSHOT~39a68b33b5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.153 ms) : 0, 673153
BytebuddyAgent [candidate] (668.953 ms) : 0, 668953
GlobalTracer [baseline] (308.689 ms) : 0, 308689
GlobalTracer [candidate] (309.377 ms) : 0, 309377
AppSec [baseline] (50.761 ms) : 0, 50761
AppSec [candidate] (50.587 ms) : 0, 50587
Remote Config [baseline] (697.151 µs) : 0, 697
Remote Config [candidate] (695.257 µs) : 0, 695
Telemetry [baseline] (7.439 ms) : 0, 7439
Telemetry [candidate] (7.443 ms) : 0, 7443
section iast
BytebuddyAgent [baseline] (783.797 ms) : 0, 783797
BytebuddyAgent [candidate] (794.825 ms) : 0, 794825
GlobalTracer [baseline] (297.022 ms) : 0, 297022
GlobalTracer [candidate] (300.332 ms) : 0, 300332
AppSec [baseline] (51.733 ms) : 0, 51733
AppSec [candidate] (48.978 ms) : 0, 48978
Remote Config [baseline] (583.771 µs) : 0, 584
Remote Config [candidate] (582.253 µs) : 0, 582
Telemetry [baseline] (7.805 ms) : 0, 7805
Telemetry [candidate] (7.826 ms) : 0, 7826
IAST [baseline] (23.303 ms) : 0, 23303
IAST [candidate] (25.331 ms) : 0, 25331
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (789.175 ms) : 0, 789175
BytebuddyAgent [candidate] (782.501 ms) : 0, 782501
GlobalTracer [baseline] (299.108 ms) : 0, 299108
GlobalTracer [candidate] (296.78 ms) : 0, 296780
AppSec [baseline] (50.495 ms) : 0, 50495
AppSec [candidate] (49.532 ms) : 0, 49532
Remote Config [baseline] (604.058 µs) : 0, 604
Remote Config [candidate] (590.553 µs) : 0, 591
Telemetry [baseline] (7.836 ms) : 0, 7836
Telemetry [candidate] (9.582 ms) : 0, 9582
IAST [baseline] (25.002 ms) : 0, 25002
IAST [candidate] (22.739 ms) : 0, 22739
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (780.546 ms) : 0, 780546
BytebuddyAgent [candidate] (780.579 ms) : 0, 780579
GlobalTracer [baseline] (297.681 ms) : 0, 297681
GlobalTracer [candidate] (296.813 ms) : 0, 296813
AppSec [baseline] (46.996 ms) : 0, 46996
AppSec [candidate] (48.377 ms) : 0, 48377
Remote Config [baseline] (611.448 µs) : 0, 611
Remote Config [candidate] (598.51 µs) : 0, 599
Telemetry [baseline] (7.686 ms) : 0, 7686
Telemetry [candidate] (6.89 ms) : 0, 6890
IAST [baseline] (26.182 ms) : 0, 26182
IAST [candidate] (25.924 ms) : 0, 25924

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-08-08T15:32:48	2024-08-08T15:39:38
git_branch	master	mattalp/update-setup-script
git_commit_date	1723106406	1723130442
git_commit_sha	`39a68b3`	`61e8eef`
release_version	1.39.0-SNAPSHOT~39a68b33b5	1.39.0-SNAPSHOT~61e8eefc93
start_time	2024-08-08T15:32:35	2024-08-08T15:39:25

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1723131924	1723131924
ci_job_id	599018643	599018643
ci_pipeline_id	41239355	41239355
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~61e8eefc93, baseline=1.39.0-SNAPSHOT~39a68b33b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (362.912 µs) : 343, 383
.   : milestone, 363,
iast (481.903 µs) : 461, 503
.   : milestone, 482,
iast_FULL (549.022 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (502.84 µs) : 482, 524
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (486.066 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (456.795 µs) : 435, 479
.   : milestone, 457,
iast_TELEMETRY_OFF (478.008 µs) : 456, 500
.   : milestone, 478,
tracing (445.961 µs) : 426, 466
.   : milestone, 446,
section candidate
no_agent (368.725 µs) : 349, 388
.   : milestone, 369,
iast (483.158 µs) : 462, 504
.   : milestone, 483,
iast_FULL (550.91 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (503.687 µs) : 481, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (480.882 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (463.374 µs) : 441, 486
.   : milestone, 463,
iast_TELEMETRY_OFF (477.227 µs) : 456, 499
.   : milestone, 477,
tracing (441.525 µs) : 421, 462
.   : milestone, 442,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	362.912 µs [343.106 µs, 382.719 µs]	-
iast	481.903 µs [460.965 µs, 502.841 µs]	118.991 µs (32.8%)
iast_FULL	549.022 µs [527.749 µs, 570.295 µs]	186.109 µs (51.3%)
iast_GLOBAL	502.84 µs [481.822 µs, 523.858 µs]	139.927 µs (38.6%)
iast_HARDCODED_SECRET_DISABLED	486.066 µs [465.002 µs, 507.13 µs]	123.154 µs (33.9%)
iast_INACTIVE	456.795 µs [434.639 µs, 478.951 µs]	93.883 µs (25.9%)
iast_TELEMETRY_OFF	478.008 µs [456.179 µs, 499.836 µs]	115.095 µs (31.7%)
tracing	445.961 µs [425.694 µs, 466.228 µs]	83.049 µs (22.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	368.725 µs [349.354 µs, 388.097 µs]	-
iast	483.158 µs [461.866 µs, 504.451 µs]	114.433 µs (31.0%)
iast_FULL	550.91 µs [529.872 µs, 571.949 µs]	182.185 µs (49.4%)
iast_GLOBAL	503.687 µs [481.376 µs, 525.998 µs]	134.961 µs (36.6%)
iast_HARDCODED_SECRET_DISABLED	480.882 µs [459.776 µs, 501.988 µs]	112.156 µs (30.4%)
iast_INACTIVE	463.374 µs [440.918 µs, 485.831 µs]	94.649 µs (25.7%)
iast_TELEMETRY_OFF	477.227 µs [455.954 µs, 498.501 µs]	108.502 µs (29.4%)
tracing	441.525 µs [420.65 µs, 462.4 µs]	72.799 µs (19.7%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~61e8eefc93, baseline=1.39.0-SNAPSHOT~39a68b33b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.339 ms) : 1320, 1359
.   : milestone, 1339,
appsec (1.732 ms) : 1709, 1755
.   : milestone, 1732,
appsec_no_iast (1.717 ms) : 1693, 1741
.   : milestone, 1717,
iast (1.51 ms) : 1488, 1532
.   : milestone, 1510,
profiling (1.478 ms) : 1454, 1503
.   : milestone, 1478,
tracing (1.475 ms) : 1450, 1500
.   : milestone, 1475,
section candidate
no_agent (1.351 ms) : 1331, 1371
.   : milestone, 1351,
appsec (1.695 ms) : 1672, 1718
.   : milestone, 1695,
appsec_no_iast (1.737 ms) : 1714, 1761
.   : milestone, 1737,
iast (1.482 ms) : 1458, 1505
.   : milestone, 1482,
profiling (1.518 ms) : 1492, 1544
.   : milestone, 1518,
tracing (1.459 ms) : 1434, 1484
.   : milestone, 1459,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.339 ms [1.32 ms, 1.359 ms]	-
appsec	1.732 ms [1.709 ms, 1.755 ms]	392.446 µs (29.3%)
appsec_no_iast	1.717 ms [1.693 ms, 1.741 ms]	377.392 µs (28.2%)
iast	1.51 ms [1.488 ms, 1.532 ms]	170.989 µs (12.8%)
profiling	1.478 ms [1.454 ms, 1.503 ms]	139.034 µs (10.4%)
tracing	1.475 ms [1.45 ms, 1.5 ms]	135.552 µs (10.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.331 ms, 1.371 ms]	-
appsec	1.695 ms [1.672 ms, 1.718 ms]	343.342 µs (25.4%)
appsec_no_iast	1.737 ms [1.714 ms, 1.761 ms]	385.883 µs (28.6%)
iast	1.482 ms [1.458 ms, 1.505 ms]	130.588 µs (9.7%)
profiling	1.518 ms [1.492 ms, 1.544 ms]	166.562 µs (12.3%)
tracing	1.459 ms [1.434 ms, 1.484 ms]	107.428 µs (7.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mattalp/update-setup-script
git_commit_date	1723106406	1723130442
git_commit_sha	`39a68b3`	`61e8eef`
release_version	1.39.0-SNAPSHOT~39a68b33b5	1.39.0-SNAPSHOT~61e8eefc93

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1723132441	1723132441
ci_job_id	599018644	599018644
ci_pipeline_id	41239355	41239355
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~61e8eefc93, baseline=1.39.0-SNAPSHOT~39a68b33b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.962 s) : 14962000, 14962000
.   : milestone, 14962000,
appsec (14.967 s) : 14967000, 14967000
.   : milestone, 14967000,
iast (18.566 s) : 18566000, 18566000
.   : milestone, 18566000,
iast_GLOBAL (17.995 s) : 17995000, 17995000
.   : milestone, 17995000,
profiling (15.527 s) : 15527000, 15527000
.   : milestone, 15527000,
tracing (15.02 s) : 15020000, 15020000
.   : milestone, 15020000,
section candidate
no_agent (15.209 s) : 15209000, 15209000
.   : milestone, 15209000,
appsec (15.247 s) : 15247000, 15247000
.   : milestone, 15247000,
iast (18.795 s) : 18795000, 18795000
.   : milestone, 18795000,
iast_GLOBAL (18.061 s) : 18061000, 18061000
.   : milestone, 18061000,
profiling (15.907 s) : 15907000, 15907000
.   : milestone, 15907000,
tracing (15.193 s) : 15193000, 15193000
.   : milestone, 15193000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.962 s [14.962 s, 14.962 s]	-
appsec	14.967 s [14.967 s, 14.967 s]	5.0 ms (0.0%)
iast	18.566 s [18.566 s, 18.566 s]	3.604 s (24.1%)
iast_GLOBAL	17.995 s [17.995 s, 17.995 s]	3.033 s (20.3%)
profiling	15.527 s [15.527 s, 15.527 s]	565.0 ms (3.8%)
tracing	15.02 s [15.02 s, 15.02 s]	58.0 ms (0.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.209 s [15.209 s, 15.209 s]	-
appsec	15.247 s [15.247 s, 15.247 s]	38.0 ms (0.2%)
iast	18.795 s [18.795 s, 18.795 s]	3.586 s (23.6%)
iast_GLOBAL	18.061 s [18.061 s, 18.061 s]	2.852 s (18.8%)
profiling	15.907 s [15.907 s, 15.907 s]	698.0 ms (4.6%)
tracing	15.193 s [15.193 s, 15.193 s]	-16.0 ms (-0.1%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~61e8eefc93, baseline=1.39.0-SNAPSHOT~39a68b33b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (2.228 ms) : 2193, 2263
.   : milestone, 2228,
iast (1.992 ms) : 1949, 2034
.   : milestone, 1992,
iast_GLOBAL (2.018 ms) : 1975, 2060
.   : milestone, 2018,
profiling (1.864 ms) : 1831, 1898
.   : milestone, 1864,
tracing (1.84 ms) : 1807, 1873
.   : milestone, 1840,
section candidate
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.221 ms) : 2186, 2256
.   : milestone, 2221,
iast (1.97 ms) : 1929, 2012
.   : milestone, 1970,
iast_GLOBAL (2.014 ms) : 1972, 2056
.   : milestone, 2014,
profiling (1.863 ms) : 1828, 1897
.   : milestone, 1863,
tracing (1.841 ms) : 1808, 1873
.   : milestone, 1841,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.466 ms [1.454 ms, 1.477 ms]	-
appsec	2.228 ms [2.193 ms, 2.263 ms]	762.17 µs (52.0%)
iast	1.992 ms [1.949 ms, 2.034 ms]	526.075 µs (35.9%)
iast_GLOBAL	2.018 ms [1.975 ms, 2.06 ms]	551.942 µs (37.7%)
profiling	1.864 ms [1.831 ms, 1.898 ms]	398.865 µs (27.2%)
tracing	1.84 ms [1.807 ms, 1.873 ms]	374.395 µs (25.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.461 ms [1.449 ms, 1.472 ms]	-
appsec	2.221 ms [2.186 ms, 2.256 ms]	760.254 µs (52.1%)
iast	1.97 ms [1.929 ms, 2.012 ms]	509.419 µs (34.9%)
iast_GLOBAL	2.014 ms [1.972 ms, 2.056 ms]	553.233 µs (37.9%)
profiling	1.863 ms [1.828 ms, 1.897 ms]	402.01 µs (27.5%)
tracing	1.841 ms [1.808 ms, 1.873 ms]	379.987 µs (26.0%)

JVM version output can contain no minor or patch suffixes

514cca3

MattAlp requested a review from a team as a code owner May 23, 2024 21:33

MattAlp requested review from dougqh and ygree May 23, 2024 21:33

MattAlp changed the title ~~JVM version output can contain no minor or patch suffixes~~ JVM version output can omit minor or patch suffixes May 23, 2024

mcculls approved these changes May 23, 2024

View reviewed changes

PerfectSlayer added comp: tooling Build & Tooling type: bug tag: no release notes Changes to exclude from release notes labels May 24, 2024

PerfectSlayer approved these changes May 24, 2024

View reviewed changes

richardstartin approved these changes May 24, 2024

View reviewed changes

smola approved these changes May 24, 2024

View reviewed changes

dougqh approved these changes Jun 3, 2024

View reviewed changes

Merge branch 'master' into mattalp/update-setup-script

61e8eef

jbachorik approved these changes Aug 8, 2024

View reviewed changes

MattAlp merged commit 594de2e into master Aug 13, 2024
80 checks passed

MattAlp deleted the mattalp/update-setup-script branch August 13, 2024 01:34

github-actions bot added this to the 1.39.0 milestone Aug 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JVM version output can omit minor or patch suffixes #7068

JVM version output can omit minor or patch suffixes #7068

MattAlp commented May 23, 2024

PerfectSlayer left a comment

smola May 24, 2024

pr-commenter bot commented Aug 8, 2024

JVM version output can omit minor or patch suffixes #7068

JVM version output can omit minor or patch suffixes #7068

Conversation

MattAlp commented May 23, 2024

What Does This Do

Motivation

Additional Notes

PerfectSlayer left a comment

Choose a reason for hiding this comment

smola May 24, 2024

Choose a reason for hiding this comment

pr-commenter bot commented Aug 8, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary