[Fleet installer] Add additional pre-verification check for IIS variables #6697

andrewlock · 2025-02-21T15:06:03Z

Summary of changes

Add additional pre-install check for whether we can read IIS config before doing anything irreversible
If the variables have not been set, then if changing the variables fails, try to revert the changes

Reason for change

Where possible, we want to revert actions safely. On the first install, if modifying IIS fails, we could theoretically end up with a strange state in their IIS config. This attempts to revert the changes if we think it's safe to do so.

Implementation details

Tries to look for the presence of the DD_INSTRUMENTATION_INSTALL_TYPE variable with value windows_fleet_installer - if we find it, then we consider this to be an "update" rather than an "initial install". We don't want to rollback the IIS changes in case of an update, so we leave the variables.

Test coverage

Yeah... I still need to add integration tests

Other details

With this design, there's still a risk that we remove variables when we shouldn't. e.g. if the customer has manually added instrumentation to the app pools using the same method, we would delete these variables.

Similarly, if they have explicitly opted out of instrumentation, by setting COR_ENABLE_PROFILING=0 for example, then this would be removed. But currently we already stomp on these (which is something else for us to think about behaviour-wise)

Requires

Add DD_INSTRUMENTATION_INSTALL_TYPE variables for known install methods #6695

bmermet · 2025-02-21T15:18:21Z

tracer/src/Datadog.FleetInstaller/ReturnCode.cs

@@ -17,4 +17,5 @@ internal enum ReturnCode
    ErrorRemovingAppPoolVariables,
    ErrorRemovingNativeLoaderFiles,
    ErrorRemovingCrashTrackerKey,
+    ErrorReadingIisConfiguration,


Not directly related to this change, but can we set the value for ErrorRemovingNativeLoaderFiles explicitly so that it doesn't accidentally get changed?

Yup, coming up in a separate PR 🙂

andrewlock · 2025-02-21T15:41:25Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6697) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6697) - mean (999ms)  : 975, 1023
     .   : milestone, 999,
    master - mean (1,002ms)  : 981, 1024
     .   : milestone, 1002,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6697) - mean (102ms)  : 100, 104
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6697) - mean (672ms)  : 658, 687
     .   : milestone, 672,
    master - mean (676ms)  : 656, 696
     .   : milestone, 676,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6697) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 92
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6697) - mean (631ms)  : 612, 650
     .   : milestone, 631,
    master - mean (635ms)  : 618, 652
     .   : milestone, 635,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6697) - mean (192ms)  : 188, 196
     .   : milestone, 192,
    master - mean (191ms)  : 188, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6697) - mean (1,113ms)  : 1090, 1136
     .   : milestone, 1113,
    master - mean (1,107ms)  : 1077, 1136
     .   : milestone, 1107,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6697) - mean (272ms)  : 267, 278
     .   : milestone, 272,
    master - mean (271ms)  : 267, 276
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (6697) - mean (864ms)  : 836, 891
     .   : milestone, 864,
    master - mean (866ms)  : 835, 898
     .   : milestone, 866,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6697) - mean (264ms)  : 259, 268
     .   : milestone, 264,
    master - mean (263ms)  : 258, 268
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (6697) - mean (844ms)  : 817, 871
     .   : milestone, 844,
    master - mean (843ms)  : 811, 876
     .   : milestone, 843,

andrewlock · 2025-02-21T20:10:28Z

Benchmarks Report for tracer 🐌

Benchmarks for #6697 compared to master:

1 benchmarks are faster, with geometric mean 1.123
1 benchmarks are slower, with geometric mean 1.135
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.15μs	48.2ns	480ns	0.0198	0.00793	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.3μs	58.1ns	406ns	0.0154	0.00515	0	5.8 KB
master	`StartStopWithChild`	net472	16μs	45.4ns	164ns	1.03	0.289	0.0882	6.22 KB
#6697	`StartStopWithChild`	net6.0	8.32μs	48.7ns	446ns	0.0119	0.00396	0	5.61 KB
#6697	`StartStopWithChild`	netcoreapp3.1	10.4μs	59.3ns	452ns	0.0155	0.00515	0	5.8 KB
#6697	`StartStopWithChild`	net472	16μs	56.2ns	210ns	1.06	0.321	0.102	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	466μs	211ns	789ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	645μs	311ns	1.21μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	853μs	424ns	1.59μs	0.422	3.3 KB
#6697	`WriteAndFlushEnrichedTraces`	net6.0	478μs	1.08μs	4.04μs	0	2.7 KB
#6697	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	642μs	376ns	1.46μs	0	2.7 KB
#6697	`WriteAndFlushEnrichedTraces`	net472	847μs	588ns	2.28μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	130μs	485ns	1.88μs	0.198	14.47 KB
master	`SendRequest`	netcoreapp3.1	146μs	181ns	677ns	0.219	17.27 KB
master	`SendRequest`	net472	0.00237ns	0.00115ns	0.00445ns	0	0 b
#6697	`SendRequest`	net6.0	129μs	635ns	2.77μs	0.198	14.47 KB
#6697	`SendRequest`	netcoreapp3.1	146μs	302ns	1.17μs	0.219	17.27 KB
#6697	`SendRequest`	net472	0.00328ns	0.00113ns	0.00438ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6697

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.5 KB	41.81 KB	305 B	0.73%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	559μs	2.35μs	8.79μs	0.571	0	0	41.5 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	727μs	4.25μs	38.5μs	0.342	0	0	41.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	872μs	4.06μs	17.2μs	8.19	2.59	0.431	53.27 KB
#6697	`WriteAndFlushEnrichedTraces`	net6.0	568μs	2.26μs	9.58μs	0.576	0	0	41.81 KB
#6697	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	677μs	3.83μs	26.8μs	0.321	0	0	41.88 KB
#6697	`WriteAndFlushEnrichedTraces`	net472	867μs	3.73μs	14.4μs	8.87	2.66	0.443	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.3μs	0.825ns	3.2ns	0.0143	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.72μs	2.47ns	9.58ns	0.0139	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.05μs	2.53ns	9.8ns	0.156	0.00102	987 B
#6697	`ExecuteNonQuery`	net6.0	1.32μs	1.12ns	4.35ns	0.0145	0	1.02 KB
#6697	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	2.2ns	8.54ns	0.0132	0	1.02 KB
#6697	`ExecuteNonQuery`	net472	2.12μs	1.72ns	6.67ns	0.157	0.00106	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.25μs	0.615ns	2.3ns	0.0137	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.53μs	0.438ns	1.58ns	0.0135	976 B
master	`CallElasticsearch`	net472	2.5μs	2.35ns	9.11ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.3μs	0.331ns	1.28ns	0.0136	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.69μs	1.07ns	4.02ns	0.0135	1.02 KB
master	`CallElasticsearchAsync`	net472	2.48μs	1.68ns	6.5ns	0.166	1.05 KB
#6697	`CallElasticsearch`	net6.0	1.23μs	0.86ns	3.22ns	0.0135	976 B
#6697	`CallElasticsearch`	netcoreapp3.1	1.63μs	0.661ns	2.56ns	0.013	976 B
#6697	`CallElasticsearch`	net472	2.42μs	1.86ns	6.95ns	0.157	995 B
#6697	`CallElasticsearchAsync`	net6.0	1.3μs	1.15ns	4.29ns	0.013	952 B
#6697	`CallElasticsearchAsync`	netcoreapp3.1	1.8μs	1.04ns	3.75ns	0.0135	1.02 KB
#6697	`CallElasticsearchAsync`	net472	2.62μs	1.74ns	6.74ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.25μs	0.418ns	1.51ns	0.0124	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.68μs	0.758ns	2.84ns	0.0131	952 B
master	`ExecuteAsync`	net472	1.92μs	0.92ns	3.56ns	0.145	915 B
#6697	`ExecuteAsync`	net6.0	1.31μs	0.748ns	2.9ns	0.0132	952 B
#6697	`ExecuteAsync`	netcoreapp3.1	1.66μs	0.724ns	2.8ns	0.0127	952 B
#6697	`ExecuteAsync`	net472	1.85μs	0.579ns	2.24ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.58μs	2.9ns	11.2ns	0.0321	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.22μs	1.99ns	7.7ns	0.0366	2.85 KB
master	`SendAsync`	net472	7.39μs	2.29ns	8.86ns	0.494	3.12 KB
#6697	`SendAsync`	net6.0	4.48μs	1.97ns	7.65ns	0.0331	2.31 KB
#6697	`SendAsync`	netcoreapp3.1	5.21μs	1.81ns	6.76ns	0.0364	2.85 KB
#6697	`SendAsync`	net472	7.4μs	2.26ns	8.75ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6697

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0	1.123	1,656.86	1,475.43

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.66μs	1.25ns	4.67ns	0.0229	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.18μs	0.612ns	2.37ns	0.0218	1.64 KB
master	`EnrichedLog`	net472	2.5μs	1.22ns	4.57ns	0.249	1.57 KB
#6697	`EnrichedLog`	net6.0	1.48μs	0.617ns	2.31ns	0.0229	1.64 KB
#6697	`EnrichedLog`	netcoreapp3.1	2.19μs	0.924ns	3.46ns	0.0224	1.64 KB
#6697	`EnrichedLog`	net472	2.44μs	2.56ns	9.9ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	98.3ns	368ns	0.0566	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	116μs	152ns	589ns	0.0579	0	4.28 KB
master	`EnrichedLog`	net472	151μs	192ns	742ns	0.676	0.225	4.46 KB
#6697	`EnrichedLog`	net6.0	114μs	212ns	823ns	0.0571	0	4.28 KB
#6697	`EnrichedLog`	netcoreapp3.1	116μs	201ns	780ns	0	0	4.28 KB
#6697	`EnrichedLog`	net472	150μs	250ns	967ns	0.679	0.226	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.98μs	1.13ns	4.37ns	0.0299	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.06μs	0.794ns	3.08ns	0.0285	2.2 KB
master	`EnrichedLog`	net472	4.79μs	1.34ns	5.18ns	0.32	2.02 KB
#6697	`EnrichedLog`	net6.0	3.14μs	0.791ns	3.06ns	0.0311	2.2 KB
#6697	`EnrichedLog`	netcoreapp3.1	4.23μs	1.34ns	5.17ns	0.0296	2.2 KB
#6697	`EnrichedLog`	net472	4.77μs	1.62ns	5.85ns	0.318	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.52μs	0.758ns	2.94ns	0.016	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.74μs	0.539ns	1.87ns	0.0157	1.14 KB
master	`SendReceive`	net472	2.05μs	0.814ns	3.15ns	0.183	1.16 KB
#6697	`SendReceive`	net6.0	1.37μs	0.622ns	2.41ns	0.0158	1.14 KB
#6697	`SendReceive`	netcoreapp3.1	1.84μs	1.6ns	6.18ns	0.0148	1.14 KB
#6697	`SendReceive`	net472	2.13μs	1.19ns	4.61ns	0.184	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.82μs	1.6ns	6.18ns	0.0226	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.85μs	1.41ns	5.47ns	0.0212	1.65 KB
master	`EnrichedLog`	net472	4.27μs	4.02ns	15.6ns	0.323	2.04 KB
#6697	`EnrichedLog`	net6.0	2.73μs	7.03ns	26.3ns	0.0218	1.6 KB
#6697	`EnrichedLog`	netcoreapp3.1	3.79μs	1.02ns	3.66ns	0.0226	1.65 KB
#6697	`EnrichedLog`	net472	4.22μs	3.86ns	14.9ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6697

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472	1.135	792.40	899.46

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	389ns	0.594ns	2.3ns	0.00805	576 B
master	`StartFinishSpan`	netcoreapp3.1	584ns	1.31ns	5.07ns	0.00778	576 B
master	`StartFinishSpan`	net472	615ns	1.6ns	6.21ns	0.0918	578 B
master	`StartFinishScope`	net6.0	486ns	0.582ns	2.18ns	0.00967	696 B
master	`StartFinishScope`	netcoreapp3.1	791ns	1.76ns	6.83ns	0.00941	696 B
master	`StartFinishScope`	net472	793ns	2.47ns	9.55ns	0.104	658 B
#6697	`StartFinishSpan`	net6.0	413ns	0.874ns	3.39ns	0.00798	576 B
#6697	`StartFinishSpan`	netcoreapp3.1	548ns	1.45ns	5.62ns	0.00765	576 B
#6697	`StartFinishSpan`	net472	636ns	1.09ns	4.09ns	0.0915	578 B
#6697	`StartFinishScope`	net6.0	543ns	1.73ns	6.72ns	0.00964	696 B
#6697	`StartFinishScope`	netcoreapp3.1	734ns	1.89ns	7.32ns	0.00916	696 B
#6697	`StartFinishScope`	net472	898ns	2.09ns	8.1ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	621ns	0.952ns	3.69ns	0.00983	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	835ns	1.49ns	5.77ns	0.00922	696 B
master	`RunOnMethodBegin`	net472	996ns	2.28ns	8.82ns	0.104	658 B
#6697	`RunOnMethodBegin`	net6.0	654ns	1.21ns	4.69ns	0.00986	696 B
#6697	`RunOnMethodBegin`	netcoreapp3.1	850ns	0.751ns	2.91ns	0.00925	696 B
#6697	`RunOnMethodBegin`	net472	1.03μs	2.34ns	9.07ns	0.104	658 B

bouwkast · 2025-02-21T22:45:58Z

tracer/src/Datadog.FleetInstaller/Commands/InstallCommand.cs

+                }
+                else
+                {
+                    log.WriteInfo($"Found instrumentation install type, but did not have expected value {expectedValue}. Will rollback IIS instrumentation if install fails");


Should we log the actual value or is that not important?

Or is it because we don't want to log the value as it may be sensitive?

Good call, I don't think we should expect it to be sensitive, I think this is just an oversight 👍

Updated in 0d0e103

Tries to look for the presence of the DD_INSTRUMENTATION_INSTALL_TYPE variable with windows_fleet_installer - if we find it, then we try to rollback the variables

andrewlock added type:enhancement Improvement to an existing feature area:ssi labels Feb 21, 2025

andrewlock requested a review from a team as a code owner February 21, 2025 15:06

bmermet reviewed Feb 21, 2025

View reviewed changes

andrewlock force-pushed the andrew/record-install-type branch from 044e0ca to bf59f82 Compare February 21, 2025 15:56

andrewlock requested a review from a team as a code owner February 21, 2025 15:56

andrewlock force-pushed the andrew/win-ssi/iis-tweaks branch from 1ac9726 to 65f3be9 Compare February 21, 2025 15:56

bouwkast approved these changes Feb 21, 2025

View reviewed changes

Base automatically changed from andrew/record-install-type to master February 24, 2025 19:24

andrewlock added 2 commits February 24, 2025 19:40

Add additional pre-verification check for IIS variables

97c65a0

Tries to look for the presence of the DD_INSTRUMENTATION_INSTALL_TYPE variable with windows_fleet_installer - if we find it, then we try to rollback the variables

PR feedback

0d0e103

andrewlock force-pushed the andrew/win-ssi/iis-tweaks branch from 65f3be9 to 0d0e103 Compare February 24, 2025 19:41

andrewlock merged commit 986c207 into master Feb 24, 2025
143 of 146 checks passed

andrewlock deleted the andrew/win-ssi/iis-tweaks branch February 24, 2025 21:45

github-actions bot added this to the vNext-v3 milestone Feb 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet installer] Add additional pre-verification check for IIS variables #6697

[Fleet installer] Add additional pre-verification check for IIS variables #6697

andrewlock commented Feb 21, 2025

bmermet Feb 21, 2025 •

edited

Loading

andrewlock Feb 21, 2025

andrewlock commented Feb 21, 2025 •

edited

Loading

andrewlock commented Feb 21, 2025

Raw results

Raw results

Raw results

More allocations ⚠️ in #6697

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6697

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6697

Raw results

Raw results

bouwkast Feb 21, 2025

bouwkast Feb 21, 2025

andrewlock Feb 24, 2025

andrewlock Feb 24, 2025

[Fleet installer] Add additional pre-verification check for IIS variables #6697

[Fleet installer] Add additional pre-verification check for IIS variables #6697

Conversation

andrewlock commented Feb 21, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

bmermet Feb 21, 2025 • edited Loading

Choose a reason for hiding this comment

andrewlock Feb 21, 2025

Choose a reason for hiding this comment

andrewlock commented Feb 21, 2025 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Feb 21, 2025

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6697

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6697

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6697

Raw results

Raw results

bouwkast Feb 21, 2025

Choose a reason for hiding this comment

bouwkast Feb 21, 2025

Choose a reason for hiding this comment

andrewlock Feb 24, 2025

Choose a reason for hiding this comment

andrewlock Feb 24, 2025

Choose a reason for hiding this comment

bmermet Feb 21, 2025 •

edited

Loading

andrewlock commented Feb 21, 2025 •

edited

Loading