Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only enable protobuf instrumentation when DSM is enabled #6691

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

vandonr
Copy link
Contributor

@vandonr vandonr commented Feb 20, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@vandonr vandonr requested review from a team as code owners February 20, 2025 16:33
@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6691) - mean (73ms)  : 70, 76
     .   : milestone, 73,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6691) - mean (1,027ms)  : 1005, 1049
     .   : milestone, 1027,
    master - mean (995ms)  : 975, 1014
     .   : milestone, 995,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6691) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6691) - mean (693ms)  : 676, 711
     .   : milestone, 693,
    master - mean (675ms)  : 658, 693
     .   : milestone, 675,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6691) - mean (94ms)  : 91, 97
     .   : milestone, 94,
    master - mean (89ms)  : 87, 90
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6691) - mean (648ms)  : 629, 667
     .   : milestone, 648,
    master - mean (631ms)  : 608, 653
     .   : milestone, 631,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6691) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (192ms)  : 187, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (6691) - mean (1,107ms)  : 1085, 1130
     .   : milestone, 1107,
    master - mean (1,111ms)  : 1086, 1137
     .   : milestone, 1111,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6691) - mean (271ms)  : 267, 276
     .   : milestone, 271,
    master - mean (272ms)  : 268, 275
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (6691) - mean (863ms)  : 828, 897
     .   : milestone, 863,
    master - mean (865ms)  : 828, 903
     .   : milestone, 865,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6691) - mean (263ms)  : 259, 267
     .   : milestone, 263,
    master - mean (262ms)  : 257, 267
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6691) - mean (842ms)  : 812, 872
     .   : milestone, 842,
    master - mean (847ms)  : 813, 881
     .   : milestone, 847,

Loading

@vandonr vandonr merged commit d6a0900 into master Feb 20, 2025
144 of 148 checks passed
@vandonr vandonr deleted the vandonr/proto branch February 20, 2025 20:20
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 20, 2025
@andrewlock andrewlock added type:enhancement Improvement to an existing feature area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:performance Performance, speed, latency, resource usage (CPU, memory) area:data-streams-monitoring area:integrations labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:data-streams-monitoring area:integrations area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:enhancement Improvement to an existing feature type:performance Performance, speed, latency, resource usage (CPU, memory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants