Add NuGet API verification check #6690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
added
the
area:builds
bouwkast
reviewed
Feb 20, 2025
bouwkast
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds an early stage in the create_draft_release workflow to check that the Nuget API key is valid
Reason for change
We recently did a release, and the "upload NuGet packages step failed". Unfortunately, this happens after the draft release is created which is essentially a one-way trip (it triggers downstream things).
Implementation details
Unfortunately, due to
dotnet nuget push --dry-runNuGet/Home#13475There's no good way to test the key Without pushing a package.
So this takes a hacky approach:
--skip-duplicateso that it becomes a no-op)Test coverage
Tested the steps locally, and they work so 🤞