Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4086 Synchronize SR info with WebViews #1784

Merged

Conversation

maxep
Copy link
Member

@maxep maxep commented Apr 17, 2024

What and why?

This fixes some discrepancies between the Webview and host app content regarding Session Replay.

Same as DataDog/dd-sdk-android#1990

How?

  • The _dd.session.plan field has been deprecated and should be removed
  • The session.has_replay and _dd.replay_stats fields should be discarded from the webview RUM event if SR is disable in the host application, to avoid orphan SR sessions

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maxep maxep self-assigned this Apr 17, 2024
@maxep maxep requested review from a team as code owners April 17, 2024 12:26
@maxep maxep force-pushed the maxep/RUM-4086/inject-has-replay-to-browser-event branch from 92ecae1 to d5bc9a6 Compare April 17, 2024 12:32
@maxep maxep mentioned this pull request Apr 17, 2024
8 tasks
@maxep maxep force-pushed the maxep/RUM-4086/inject-has-replay-to-browser-event branch from d5bc9a6 to 6abffa1 Compare April 17, 2024 12:51
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Apr 17, 2024

Datadog Report

Branch report: maxep/RUM-4086/inject-has-replay-to-browser-event
Commit report: 5d3a8dd
Test service: dd-sdk-ios

✅ 0 Failed, 2799 Passed, 0 Skipped, 24m 22.75s Wall Time
🔻 Test Sessions change in coverage: 12 decreased, 2 increased

🔻 Code Coverage Decreases vs Default Branch (12)

This report shows up to 5 code coverage decreases.

  • test DatadogRUMTests tvOS 80.82% (-0.21%) - Details
  • test DatadogCoreTests tvOS 79.45% (-0.17%) - Details
  • test IntegrationScenarios 3.51% (-0.17%) - Details
  • test DatadogInternalTests iOS 80.08% (-0.08%) - Details
  • test DatadogTraceTests tvOS 49.48% (-0.06%) - Details

Copy link
Member

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxep maxep merged commit 30ed013 into feature/webview-replay Apr 19, 2024
8 checks passed
@maxep maxep deleted the maxep/RUM-4086/inject-has-replay-to-browser-event branch April 19, 2024 11:42
@maciejburda maciejburda mentioned this pull request May 7, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants