Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android and Android TV Monitoring Formatting Edit #966

Merged
merged 4 commits into from
Jul 20, 2022

Conversation

alai97
Copy link
Contributor

@alai97 alai97 commented Jun 29, 2022

What does this PR do?

Small spacing nits.

Motivation

Batch edit for Error Tracking.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@alai97 alai97 requested review from a team as code owners June 29, 2022 23:53
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #966 (158e017) into master (fab5eb6) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
- Coverage   83.09%   83.03%   -0.07%     
==========================================
  Files         267      267              
  Lines        9086     9079       -7     
  Branches     1465     1461       -4     
==========================================
- Hits         7550     7538      -12     
- Misses       1135     1139       +4     
- Partials      401      402       +1     
Impacted Files Coverage Δ
...android/log/internal/logger/TelemetryLogHandler.kt 75.00% <0.00%> (-25.00%) ⬇️
...g/internal/domain/event/DdSpanToSpanEventMapper.kt 96.08% <0.00%> (-3.92%) ⬇️
...nternal/persistence/file/batch/BatchFileHandler.kt 78.30% <0.00%> (-2.83%) ⬇️
...com/datadog/android/compose/InteractionTracking.kt 73.55% <0.00%> (-2.31%) ⬇️
...tadog/android/tv/LeanbackViewAttributesProvider.kt 84.21% <0.00%> (-2.00%) ⬇️
.../datadog/android/rum/webview/RumWebChromeClient.kt 80.00% <0.00%> (-1.48%) ⬇️
.../android/rum/internal/tracking/ViewLoadingTimer.kt 93.33% <0.00%> (-0.22%) ⬇️
.../com/datadog/android/tracing/TracingInterceptor.kt 97.78% <0.00%> (-0.06%) ⬇️
.../src/main/kotlin/com/datadog/android/log/Logger.kt 95.83% <0.00%> (-0.03%) ⬇️
...kotlin/com/datadog/android/DatadogEventListener.kt 98.48% <0.00%> (-0.02%) ⬇️
... and 9 more

@alai97 alai97 requested a review from xgouchet June 30, 2022 21:45
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but LGTM

@alai97 alai97 merged commit c3138f4 into master Jul 20, 2022
@alai97 alai97 deleted the alai97/fixing-code-snippet-spacing branch July 20, 2022 01:05
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants