RUMM-2183 Nightly tests for ConfigurationBuilder#setVitalsUpdateFrequency #929
Conversation
mariusc83
force-pushed
the
mconstantin/rumm-2076/mobile-vitals-uptate-frequency-option
branch
from
d0feae5 to
b63545e
Compare
| // Give some time to vitals monitors to be updated | ||
| Thread.sleep(5000) | ||
| scenario.onActivity { | ||
| InstrumentationRegistry.getInstrumentation().callActivityOnPause(it) |
There was a problem hiding this comment.
why do we need to call pause and then resume?
There was a problem hiding this comment.
Just because I want to make sure I get some choreographer updates.
There was a problem hiding this comment.
I was thinking that Choreographer always does postFrameCallback, even if nothing happens on the screen (so it is sufficient only to launch an activity), but maybe my knowledge is wrong.
| initializeSdk( | ||
| InstrumentationRegistry.getInstrumentation().targetContext, | ||
| TrackingConsent.GRANTED, | ||
| Configuration |
There was a problem hiding this comment.
I would suggest either to extract configuration into a dedicated variable to reduce the indent level, or extract custom viewStrategy into a dedicated class for the same purpose.
Codecov Report
@@ Coverage Diff @@
## mconstantin/rumm-2076/mobile-vitals-uptate-frequency-option #929 +/- ##
===============================================================================================
+ Coverage 82.64% 82.79% +0.14%
===============================================================================================
Files 265 265
Lines 9006 9006
Branches 1449 1449
===============================================================================================
+ Hits 7443 7456 +13
+ Misses 1167 1156 -11
+ Partials 396 394 -2
|
mariusc83
force-pushed
the
mconstantin/rumm-2183/vitals-update-frequency-api-nightly-tests
branch
2 times, most recently
from
00f3f1c to
6c6a438
Compare
| // Give some time to vitals monitors to be updated | ||
| Thread.sleep(5000) | ||
| scenario.onActivity { | ||
| InstrumentationRegistry.getInstrumentation().callActivityOnPause(it) |
There was a problem hiding this comment.
I was thinking that Choreographer always does postFrameCallback, even if nothing happens on the screen (so it is sufficient only to launch an activity), but maybe my knowledge is wrong.
| exclude = listOf(VitalsUpdateFrequency.NEVER) | ||
| ) | ||
| val testMethodName = "rum_config_set_vitals_update_frequency" | ||
| // we need to initialize the SDK on the Main Thread (Looper thread) otherwise the |
There was a problem hiding this comment.
very minor: this comment belongs to L750.
There was a problem hiding this comment.
@0xnm regarding the choreographer...you are not wrong, for some reason during my tests sometimes it was not triggered if I didn't play a bit with the activity.
There was a problem hiding this comment.
very minor: this comment belongs to L750.
yeah, I think it was messed up after I did the refactor by extracting the variable.
mariusc83
force-pushed
the
mconstantin/rumm-2183/vitals-update-frequency-api-nightly-tests
branch
from
6c6a438 to
679fc51
Compare
mariusc83
deleted the
mconstantin/rumm-2183/vitals-update-frequency-api-nightly-tests
branch
What does this PR do?
Adding the nightly tests for newly introduce API :
ConfigurationBuilder#setVitalsUpdateFrequencyIncreasing the nightly tests coverage to 0.94
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)