Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-1759 Prevent crash on uncaught exception #754

Merged

Conversation

xgouchet
Copy link
Member

@xgouchet xgouchet commented Nov 9, 2021

What does this PR do?

Prevent app from crashing when calling the DatadogExceptionHandler.uncaughtException() method.
Fixes #749

@xgouchet xgouchet requested a review from a team as a code owner November 9, 2021 10:06
@xgouchet xgouchet force-pushed the xgouchet/RUMM-1759/crash_uncaught_exception branch from 1146710 to 75351f3 Compare November 9, 2021 10:08
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #754 (75351f3) into release/1.11.0 (4b60fff) will decrease coverage by 0.24%.
The diff coverage is 44.44%.

@@                 Coverage Diff                  @@
##             release/1.11.0     #754      +/-   ##
====================================================
- Coverage             88.84%   88.60%   -0.24%     
+ Complexity             1720     1714       -6     
====================================================
  Files                   189      190       +1     
  Lines                  5689     5703      +14     
  Branches                700      701       +1     
====================================================
- Hits                   5054     5053       -1     
- Misses                  397      408      +11     
- Partials                238      242       +4     
Impacted Files Coverage Δ
.../datadog/android/core/internal/thread/ThreadExt.kt 25.00% <25.00%> (ø)
...roid/core/internal/thread/ThreadPoolExecutorExt.kt 90.00% <83.33%> (-10.00%) ⬇️
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 81.82% <0.00%> (-4.55%) ⬇️
...droid/rum/tracking/ActivityViewTrackingStrategy.kt 84.62% <0.00%> (-3.85%) ⬇️
.../android/error/internal/DatadogExceptionHandler.kt 93.10% <0.00%> (-3.45%) ⬇️
...l/net/info/BroadcastReceiverNetworkInfoProvider.kt 77.08% <0.00%> (-2.08%) ⬇️
...ore/internal/constraints/DatadogDataConstraints.kt 91.89% <0.00%> (-1.35%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 95.09% <0.00%> (-0.87%) ⬇️
...m/internal/domain/scope/ExternalResourceTimings.kt 79.41% <0.00%> (ø)
...internal/tracking/JetpackViewAttributesProvider.kt 86.96% <0.00%> (ø)
... and 5 more

.gitlab-ci.yml Outdated
@@ -355,3 +355,15 @@ notify:dogfood-bridge:
- pip3 install GitPython requests
- aws ssm get-parameter --region us-east-1 --name ci.dd-sdk-android.gh_token --with-decryption --query "Parameter.Value" --out text >> ./gh_token
- python3 dogfood.py -v $CI_COMMIT_TAG -t bridge

notify:dogfood-gradle-plugin:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this part of this PR ?

@xgouchet xgouchet changed the base branch from master to release/1.11.0 November 9, 2021 10:30
@xgouchet xgouchet requested a review from mariusc83 November 9, 2021 10:30
@xgouchet xgouchet merged commit b804b68 into release/1.11.0 Nov 9, 2021
@xgouchet xgouchet deleted the xgouchet/RUMM-1759/crash_uncaught_exception branch November 9, 2021 11:41
@xgouchet xgouchet added this to the 1.11.0 milestone Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in DatadogExceptionHandler.uncaughtException
4 participants