Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enums to match RUM event schema #2482

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

xgouchet
Copy link
Member

What does this PR do?

Update the enums we use in our API to match some constants available in the RUM schema

Motivation

Ensure a better consistency across platforms.

@xgouchet xgouchet requested review from a team as code owners January 13, 2025 09:55
@xgouchet xgouchet force-pushed the xgouchet/missing_rum_enum_constants branch from 24dd35a to 00b9ef7 Compare January 13, 2025 11:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.04%. Comparing base (3adfe60) to head (00b9ef7).
Report is 37 commits behind head on develop.

Files with missing lines Patch % Lines
...trace/internal/domain/event/BaseSpanEventMapper.kt 66.67% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2482      +/-   ##
===========================================
+ Coverage    69.92%   70.04%   +0.12%     
===========================================
  Files          786      786              
  Lines        29301    29406     +105     
  Branches      4889     4902      +13     
===========================================
+ Hits         20486    20596     +110     
- Misses        7442     7455      +13     
+ Partials      1373     1355      -18     
Files with missing lines Coverage Δ
...tlin/com/datadog/android/api/context/DeviceType.kt 100.00% <100.00%> (ø)
...n/kotlin/com/datadog/android/rum/RumErrorSource.kt 100.00% <100.00%> (ø)
...g/android/rum/internal/domain/scope/RumEventExt.kt 93.77% <100.00%> (+0.26%) ⬆️
...trace/internal/domain/event/BaseSpanEventMapper.kt 94.59% <66.67%> (+11.74%) ⬆️

... and 40 files with indirect coverage changes

@xgouchet xgouchet merged commit 54a38b6 into develop Jan 13, 2025
23 checks passed
@xgouchet xgouchet deleted the xgouchet/missing_rum_enum_constants branch January 13, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants