Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-6199: Add Semantics mapper for Switch #2471

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jonathanmos
Copy link
Member

@jonathanmos jonathanmos commented Jan 1, 2025

What does this PR do?

Adds support for the Compose Switch component. For the masked state returns an empty track, for the off state returns a white thumb on a white track, for the on state returns a black thumb on a black track. These colors are temporary until we can find a way to get the actual colors for the thumb and track.

Masked
Screenshot 2025-01-05 at 19 54 11

Off
Screenshot 2025-01-05 at 19 48 01

On
Screenshot 2025-01-05 at 12 08 52

Motivation

Additional mapper to support Compose.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 98.52941% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.03%. Comparing base (c29bc1f) to head (c9d5572).
Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
...nal/mappers/semantics/SwitchSemanticsNodeMapper.kt 98.48% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2471      +/-   ##
===========================================
+ Coverage    69.91%   70.03%   +0.13%     
===========================================
  Files          787      788       +1     
  Lines        29347    29501     +154     
  Branches      4895     4914      +19     
===========================================
+ Hits         20516    20661     +145     
- Misses        7470     7477       +7     
- Partials      1361     1363       +2     
Files with missing lines Coverage Δ
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 79.07% <100.00%> (+0.25%) ⬆️
...nal/mappers/semantics/SwitchSemanticsNodeMapper.kt 98.48% <98.48%> (ø)

... and 33 files with indirect coverage changes

@jonathanmos jonathanmos marked this pull request as ready for review January 5, 2025 08:58
@jonathanmos jonathanmos requested review from a team as code owners January 5, 2025 08:58
@jonathanmos jonathanmos force-pushed the jmoskovich/RUM-6199/compose-switch branch from 13d8e55 to 533dc30 Compare January 5, 2025 17:46
@jonathanmos jonathanmos force-pushed the jmoskovich/RUM-6199/compose-switch branch from 533dc30 to 462c269 Compare January 6, 2025 12:21
@jonathanmos jonathanmos force-pushed the jmoskovich/RUM-6199/compose-switch branch from 462c269 to c9d5572 Compare January 7, 2025 10:02
@jonathanmos jonathanmos merged commit ce2ed62 into develop Jan 7, 2025
23 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/RUM-6199/compose-switch branch January 7, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants