Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-7806 improve the view duration accuracy #2467

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

xgouchet
Copy link
Member

What does this PR do?

Use a more accurate view duration : do not update the view duration after the view has been stopped.

@xgouchet xgouchet requested review from a team as code owners December 19, 2024 15:33
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.00%. Comparing base (9d727b7) to head (19e004d).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2467      +/-   ##
===========================================
- Coverage    70.01%   70.00%   -0.01%     
===========================================
  Files          786      786              
  Lines        29298    29302       +4     
  Branches      4890     4891       +1     
===========================================
+ Hits         20511    20512       +1     
- Misses        7430     7435       +5     
+ Partials      1357     1355       -2     
Files with missing lines Coverage Δ
.../android/rum/internal/domain/scope/RumViewScope.kt 95.26% <100.00%> (+0.02%) ⬆️

... and 22 files with indirect coverage changes

Base automatically changed from xgouchet/invalid_duration_log to develop December 20, 2024 09:50
@xgouchet xgouchet merged commit 3adfe60 into develop Dec 20, 2024
22 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-7806/accurate_view_duration branch December 20, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants