Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve telemetry on invalid view duration #2466

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

xgouchet
Copy link
Member

What does this PR do?

In order to get a better signal from our telemetry, we update the logs when a view ends with a duration less than or equal to zero:

  • We distinguish negative and nul duration
  • We add additional attributes to get more insights
  • We exclude legitimate nul duration cases for background crashes.

@xgouchet xgouchet requested review from a team as code owners December 19, 2024 12:19
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.01%. Comparing base (f7f80e2) to head (9d727b7).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/rum/internal/domain/scope/RumViewScope.kt 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2466      +/-   ##
===========================================
- Coverage    70.13%   70.01%   -0.12%     
===========================================
  Files          786      786              
  Lines        29288    29298      +10     
  Branches      4889     4890       +1     
===========================================
- Hits         20540    20511      -29     
- Misses        7418     7430      +12     
- Partials      1330     1357      +27     
Files with missing lines Coverage Δ
.../android/rum/internal/domain/scope/RumViewScope.kt 95.24% <95.00%> (-0.40%) ⬇️

... and 28 files with indirect coverage changes

@xgouchet xgouchet merged commit 83735cf into develop Dec 20, 2024
23 checks passed
@xgouchet xgouchet deleted the xgouchet/invalid_duration_log branch December 20, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants