-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-7528 Introduce the setLastInteractionIdentifier Public API #2428
RUM-7528 Introduce the setLastInteractionIdentifier Public API #2428
Conversation
31b857c
to
6c04bce
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/view-loading-times #2428 +/- ##
==============================================================
+ Coverage 70.00% 70.11% +0.11%
==============================================================
Files 775 775
Lines 28676 28694 +18
Branches 4807 4809 +2
==============================================================
+ Hits 20072 20116 +44
+ Misses 7278 7251 -27
- Partials 1326 1327 +1
|
6c04bce
to
e8122d9
Compare
@@ -260,7 +261,7 @@ data class RumConfiguration internal constructor( | |||
} | |||
|
|||
/** | |||
* Sets the identifier strategy for initial network resources used to compute the time to network settled | |||
* Sets a custom identifier for initial network resources used to compute the time to network settled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Nitpick: this should belong in the previous PR
85893e3
to
48ab0a2
Compare
e8122d9
to
5a2c9be
Compare
What does this PR do?
Following the RFC we are introducing the
setLastInteractionIdentifier
API as part of theRumConfiguration#Builder
in order to provide external control on which action intercepted on the previous view will be considered as the last interaction leading to the next view needed in theinteraction-to-next-view
metric computation. The default identifier being used is aTimeBasedInteractionIdentifier
with a default threshold interval of 3000ms. More about this you can read in the class docs in the PR itself. This could be re - used by our users in the Configuration Builder by changing the time interval to their internal needs.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)